Skip to content

Redesign: display online meeting#11075

Merged
ferblape merged 17 commits intofeature/redesignfrom
feature/redesign-display-online-meeting
Jun 29, 2023
Merged

Redesign: display online meeting#11075
ferblape merged 17 commits intofeature/redesignfrom
feature/redesign-display-online-meeting

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented Jun 21, 2023

🎩 What? Why?

Show online status as it was an address field. Includes as well a mobile version of the calendar-address-map widget and the refactorization of the other uses of the static map.

📌 Related Issues

📷 Screenshots

♥️ Thank you!

@Crashillo Crashillo requested review from ferblape and furilo June 21, 2023 08:41
@Crashillo Crashillo added the project: redesign Barcelona City Council contract label Jun 21, 2023
@Crashillo Crashillo requested a review from a team June 22, 2023 10:47
Copy link
Copy Markdown
Member

@NilHomedes NilHomedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Crashillo, thanks for the job 👍 I leave my review as follows:

I also noticed a wired behaviour with the grid. See the following examples:
a) Link with some dashes:
Screenshot 2023-06-23 at 14-20-38 Test Online Meeting - Metadecidim

b) Long link without any dash in the url:
Screenshot 2023-06-23 at 14-19-56 Test Online Meeting - Metadecidim

As we are running out of time, maybe we can leave it as it is now and in further iterations rethink this. I don't see this as critical, what do you think @carolromero ?

  • There's an blank space between the Author and the description text. I've seen more of these blank spaces, so maybe we can open another issue to tackle this?
    Captura de pantalla de 2023-06-23 14-01-33

Online meeting embed

  • The text "This meeting is happening right now" should be bigger, maybe a Heading2
  • The rest of the text should not be bold. Following the same styles as the description meeting text.
  • The CTA should be "Join Meeting" instead of "Register"
    More or less, this is how we would like it to be:
    Screenshot 2023-06-23 at 14-52-46 upload_b0284c8f0db8a0d2236559855dc39e50 png (PNG Image 883 × 346 pixels)

Mobile

  • It's kind of messy this section (see the screenshot). I don't know how but we need to enhance this. I remember that at some point in the Figma, the Register CTA was fixed in the bottom of the mobile phone screen, as it was the support CTA button in proposals. Are we going to do this or what could be a solution?
    photo_2023-06-23_15-05-08

@Crashillo
Copy link
Copy Markdown
Contributor Author

Crashillo commented Jun 23, 2023

There's an blank space between the Author and the description text. I've seen more of these blank spaces, so maybe we can open another issue to tackle this?

This is being done in #10883. Just for the record, the space you're pointing out is the common separator for each section.

@furilo
Copy link
Copy Markdown
Contributor

furilo commented Jun 27, 2023

Are we going to do this or what could be a solution?

@NilHomedes We discarded that path a time ago, so I don't think its feasible to think about to retake it now.

@ferblape
Copy link
Copy Markdown
Contributor

@NilHomedes can we move forward this PR to maintainers?

Copy link
Copy Markdown
Member

@NilHomedes NilHomedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, we can move forward to not block you anymore with that PR.

But this is not working properly:

c) If "Open in live event page" --> decidim-redesign.populate.tools/processes/Decidim4Dummies/f/168/meetings/1815/live_event
In case of c) scenario, maybe it's better to replace the url for a text like "Join meeting"

@ferblape ferblape requested a review from fblupi June 28, 2023 09:57
@ferblape
Copy link
Copy Markdown
Contributor

OK, thanks, feel free to open an issue so this can be tackle separately.

Copy link
Copy Markdown
Member

@fblupi fblupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ferblape ferblape merged commit b823aa1 into feature/redesign Jun 29, 2023
@ferblape ferblape deleted the feature/redesign-display-online-meeting branch June 29, 2023 11:31
entantoencuanto added a commit that referenced this pull request Jun 30, 2023
…-process

* feature/redesign:
  Redesign: display online meeting (#11075)
  Redesign: home menu content block (#11048)
  Redesign: home (#10920)
  Remove widgets and embeds (#11096)
  Redesign / Complete card G cell specs (#11094)
  Redesign: processes assemblies metadata content blocks (#10637)
  Redesign: vertical margin inside the callouts (#11071)
  Redesign / Update package-lock  (#11091)
  Use the component name in the sidebar title (#11088)
  Redesign: layout center (#11068)
  Redesign: display only public users followings in following profile tab (#11051)
  Redesign: fix cards (#11072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

5 participants