Redesign: home menu content block#11048
Merged
ferblape merged 37 commits intofeature/redesignfrom Jun 29, 2023
Merged
Conversation
…thub.com/decidim/decidim into feature/redesign-home-menu-content-block
…thub.com/decidim/decidim into feature/redesign-home-menu-content-block
8e44338 to
ae39790
Compare
…thub.com/decidim/decidim into feature/redesign-home-menu-content-block
…into feature/redesign-home-menu-content-block
ferblape
approved these changes
Jun 22, 2023
furilo
approved these changes
Jun 22, 2023
carolromero
requested changes
Jun 23, 2023
Member
There was a problem hiding this comment.
- Now that we have the homepage menu as a content block we need to remove the breadcrumb menu from the home page: https://www.figma.com/proto/3CNSXeFTMtUl2QdEUgLpEo/Decidim-PX-(DONT-EDIT)?page-id=5604%3A308577&node-id=5604-308578&viewport=321%2C48%2C0.78&scaling=min-zoom&starting-point-node-id=5604%3A308578&hide-ui=1
…thub.com/decidim/decidim into feature/redesign-home-menu-content-block
…into feature/redesign-home-menu-content-block
Contributor
|
@decidim/product in mobile, for the home page had this dropdown: 
But this means a slightly new design from the other menu block, and since we already have the hamburger, I would just simply hide the menu block for the time being. OK? |
Member
|
@furilo I agree, let's hide it from mobile. |
…thub.com/decidim/decidim into feature/redesign-home-menu-content-block
carolromero
approved these changes
Jun 28, 2023
Member
carolromero
left a comment
There was a problem hiding this comment.
@jorgeatgu the content block works well anywhere on the home page, good job!
fblupi
requested changes
Jun 29, 2023
decidim-core/app/cells/decidim/content_blocks/global_menu_cell.rb
Outdated
Show resolved
Hide resolved
…into feature/redesign-home-menu-content-block
Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>
entantoencuanto
added a commit
that referenced
this pull request
Jun 30, 2023
…-process * feature/redesign: Redesign: display online meeting (#11075) Redesign: home menu content block (#11048) Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088) Redesign: layout center (#11068) Redesign: display only public users followings in following profile tab (#11051) Redesign: fix cards (#11072)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Add a home menu as a content-block
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
Please add screenshots of the changes you are proposing
