Redesign: processes assemblies metadata content blocks#10637
Merged
ferblape merged 39 commits intofeature/redesignfrom Jun 26, 2023
Merged
Redesign: processes assemblies metadata content blocks#10637ferblape merged 39 commits intofeature/redesignfrom
ferblape merged 39 commits intofeature/redesignfrom
Conversation
5449363 to
c4bd48e
Compare
ferblape
reviewed
May 11, 2023
ferblape
approved these changes
May 11, 2023
furilo
approved these changes
May 11, 2023
carolromero
requested changes
May 16, 2023
Member
carolromero
left a comment
There was a problem hiding this comment.
Hi @entantoencuanto, here's some feedback on this:
- Include the "Short Description" field in the About page. It is usually not very long and no context is lost.
- On mobile, the metadata should be displayed at the end and not at the beginning.
Note: There are some issues related to navigation and the breadcrumb menu but we'll discuss them in another issue focused on the menu behavior.
Contributor
|
As we talked yesterday in the Product meeting, we are going to show all the content of the about in the current main block. So @entantoencuanto maybe you can
|
Contributor
|
I'm realizing that the behaviour was already present in Assemblies... https://meta.decidim.org/assemblies/eix-comunitat?locale=es |
c403538 to
8845067
Compare
30a9534 to
93e8d24
Compare
3ce2b48 to
91a840c
Compare
Contributor
Author
|
Hi, @carolromero, we have included most of the indicated changes:
You can check the changes in https://decidim-redesign.populate.tools/assemblies/eix-comunitat and https://decidim-redesign.populate.tools/processes/bug-report |
9c18f2d to
046f8c6
Compare
046f8c6 to
782d51d
Compare
…blies-details-page * feature/redesign: (71 commits) Unskip tests (#10951) Fix failing specs Redesign sortitions (#10831) Redesign: data toggle (#10886) Redesign: collaborative drafts (#10729) Redesign: pending pages (#10944) Redesign: my account (#10904) use foundation classes instead of default html validation (#10921) Fix failings redesign specs Add gitpod support (#10641) Fix pipeline after #10409 (#10670) Upgrade webpack and other javascript libraries (#10643) New Crowdin updates (#10409) Refactor attachment title (#10103) Fix for exporting hidden moderated proposals (#10630) Fix Exception as admin on a Proposal with meeting author (#10628) Fix: Deleted and hidden comments are exported (#10629) Rename "terms and conditions" to "terms of service" (#10614) Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606) Standardize the format of the words "they will" (#10617) ...
carolromero
requested changes
Jun 16, 2023
Member
carolromero
left a comment
There was a problem hiding this comment.
@entantoencuanto sorry for the delay with this one!
In any case, the duration field is in both the type and duration and date metadata blocks, should I remove this from one of the blocks?
Yes, please. Let's remove it from the dates metadata block, and we're good to go. Thank you!
carolromero
approved these changes
Jun 21, 2023
fblupi
requested changes
Jun 23, 2023
decidim-assemblies/app/cells/decidim/assemblies/content_blocks/dates_metadata_cell.rb
Outdated
Show resolved
Hide resolved
decidim-assemblies/app/cells/decidim/assemblies/content_blocks/main_data_cell.rb
Outdated
Show resolved
Hide resolved
decidim-assemblies/app/cells/decidim/assemblies/content_blocks/metadata_cell.rb
Outdated
Show resolved
Hide resolved
decidim-assemblies/app/presenters/decidim/assemblies/assembly_presenter.rb
Show resolved
Hide resolved
decidim-assemblies/app/cells/decidim/assemblies/content_blocks/extra_data_cell.rb
Outdated
Show resolved
Hide resolved
decidim-core/app/cells/decidim/content_blocks/participatory_space_main_data/title.erb
Show resolved
Hide resolved
...cipatory_processes/app/cells/decidim/participatory_processes/content_blocks/metadata_cell.rb
Outdated
Show resolved
Hide resolved
decidim-assemblies/app/cells/decidim/assemblies/content_blocks/main_data_cell.rb
Outdated
Show resolved
Hide resolved
…/main_data_cell.rb Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>
…/main_data_cell.rb Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>
fblupi
approved these changes
Jun 26, 2023
ferblape
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Define a method in area presenter to include area type in name if present * Refactor description view in processes to use a presenter * Add description view to assemblies and link from main data content block * Replace start_date and end_date items by date_range in process about page * Add duration and closing date elements to assembly about page * Normalize assemblies translations * move style form about page to core * Fix sanitizer on description pages to allow embedded videos * Add tests for description pages * Adapt triggerWarnings method used when iframes are present to redesign * Rename metadata content blocks in participatory spaces and groups * Define and register metadata content blocks on assemblies and processes * Include full description in main data cell * Remove link to about page in main data content block * Remove description paths, actions, views and references on assemblies and participatory processes * Skip REDESIGN_PENDING tests of description pages pending to adapt to content blocks * Remove unused translation * Add description attributes of metadata content blocks to ignore_unused * add grid for metadata block * fix style glitches on modal steps * wrap description with a show more/less content * Add missing translations taken fron announcement with truncation branch * remove possible margin top of first childs * Include purpose_of_action, internal_organisation and composition in main data of assemblies * Fix assembly type item in extra data content block * Fix date format * Split assemblies metadata content block in two content blocks * Remove date range from metadata participatory processes content block * Extract social handler links to a content block * Include missing content block in test * Remove duration from assemblies dates metadata content block * Remove unused translation * Update decidim-assemblies/app/cells/decidim/assemblies/content_blocks/main_data_cell.rb Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com> * Update decidim-assemblies/app/cells/decidim/assemblies/content_blocks/main_data_cell.rb Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com> * Change endless method definitions * Use a presented assembly in extra data content block --------- Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com> Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>
ferblape
added a commit
that referenced
this pull request
Jun 28, 2023
* add styles and layout to homepage * add class to sections * highlighted_initiatives * sub_hero * add home-section-header and add card to initiatives * add grid-3cols to cards * add card-g to conferences * add card-g to assemblies * add card-g to processes * add header and button-show-all to the rest of the content blocks * add grid to initiatives * Use highlighted_meetings content block on homepage instead of deprecated upcoming_meetings * Remove deprecated upcoming_meetings content block * Adapt upcoming_meetings cell spec to the redesigned highlighted_meetings content block * content-banner * sub_hero and footer_sub_hero * last activity * home section * block how to participate * add styles to section tittle * single process * votings and consultations * metrics * how to participate * responsive * responsive * revert grid * remove unused cssClasses * Move method to metric charts presenter root class * Allow participatory_space_metrics_cell to display not highlighted metrics * Define organization metrics content block and use it in registry * add classes to html-block * Remove deprecated content block * Remove deprecated methods Some method marked as deprecated are used in admin dashboard * Adapt tests to redesign * add border-0 to avoid separator between content-block * remove unused cssClasses * Allow to set a see_all_path option in meetings content block involved cells and use it for homepage meetings block * hero aspect ratio * responsive * hero height * center background image * update the conference title * remove heart icon * fix locales * update highlighted initiatives * add background-image to content-banner and align the content * add subtitle to button * add icons to content banner * add editor-conter to description * add editor-content to sub-hero * add border and spacing between activity-blocks * add styles to embed videos * styles * fix merge * add margin to area-chart * add no-underline to register button * fix test: replace card--assembly by card__grid * order scss * fix test: replace highlighted-processes by highlighted_processes * lint scss * remove unused keys * replace subhero * fix test * use the card__grid class for the home content-block tests * remove duplicate text * add color:white to editor-content * remove highlighted_content_banner padding * center align the footer_sub_hero * fix highlighted_initiatives * Adapt upcoming meetings content block spec to highlighted meetings block * Skip accessibility tests when redesign is not enabled * Adapt tests * Unify code of highlighted assemblies, conferences and initiatives home content blocks * Update decidim-consultations/app/cells/decidim/consultations/content_blocks/highlighted_consultations/show.erb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Use generic content block for highlighted votings in home * Use generic content block for highlighted processes in home * Replace html content block with redesigned version * Use limited spaces on highlighted spaces content block * Update selector in test * Update method name in test * Don't use generic limited_highlighted_spaces method for processes content block * Join highlighted and not highlighted stats in the same container of stats content block * add margin between the button and text. Same font-size for the texts * Accept suggestion Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com> * Redesign: processes assemblies metadata content blocks (#10637) * Define a method in area presenter to include area type in name if present * Refactor description view in processes to use a presenter * Add description view to assemblies and link from main data content block * Replace start_date and end_date items by date_range in process about page * Add duration and closing date elements to assembly about page * Normalize assemblies translations * move style form about page to core * Fix sanitizer on description pages to allow embedded videos * Add tests for description pages * Adapt triggerWarnings method used when iframes are present to redesign * Rename metadata content blocks in participatory spaces and groups * Define and register metadata content blocks on assemblies and processes * Include full description in main data cell * Remove link to about page in main data content block * Remove description paths, actions, views and references on assemblies and participatory processes * Skip REDESIGN_PENDING tests of description pages pending to adapt to content blocks * Remove unused translation * Add description attributes of metadata content blocks to ignore_unused * add grid for metadata block * fix style glitches on modal steps * wrap description with a show more/less content * Add missing translations taken fron announcement with truncation branch * remove possible margin top of first childs * Include purpose_of_action, internal_organisation and composition in main data of assemblies * Fix assembly type item in extra data content block * Fix date format * Split assemblies metadata content block in two content blocks * Remove date range from metadata participatory processes content block * Extract social handler links to a content block * Include missing content block in test * Remove duration from assemblies dates metadata content block * Remove unused translation * Update decidim-assemblies/app/cells/decidim/assemblies/content_blocks/main_data_cell.rb Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com> * Update decidim-assemblies/app/cells/decidim/assemblies/content_blocks/main_data_cell.rb Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com> * Change endless method definitions * Use a presented assembly in extra data content block --------- Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com> Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com> * Redesign / Complete card G cell specs (#11094) * Complete Cell G specs * Cleanup specs * Remove widgets and embeds (#11096) * Apply feedback --------- Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com> Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> Co-authored-by: Fernando Blat <fernando@blat.es> Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com> Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
entantoencuanto
added a commit
that referenced
this pull request
Jun 28, 2023
* feature/redesign: Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088)
entantoencuanto
added a commit
that referenced
this pull request
Jun 28, 2023
* feature/redesign: Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088)
entantoencuanto
added a commit
that referenced
this pull request
Jun 30, 2023
…-process * feature/redesign: Redesign: display online meeting (#11075) Redesign: home menu content block (#11048) Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088) Redesign: layout center (#11068) Redesign: display only public users followings in following profile tab (#11051) Redesign: fix cards (#11072)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR:
📌 Related Issues
Link your PR to an issue
Testing
Visit a participatory process or assembly with the main data content block enable and click on "More info" link behind the short description
Example of metadata content block in assembly: https://decidim-redesign.populate.tools/assemblies/eix-comunitat
Example of metadata content block in participatory process: https://decidim-redesign.populate.tools/processes/Decidim4Dummies
📷 Screenshots
Please add screenshots of the changes you are proposing
