Skip to content

Redesign sortitions#10831

Merged
ferblape merged 36 commits intofeature/redesignfrom
feature/redesign-sortitions
Jun 7, 2023
Merged

Redesign sortitions#10831
ferblape merged 36 commits intofeature/redesignfrom
feature/redesign-sortitions

Conversation

@jorgeatgu
Copy link
Copy Markdown
Contributor

@jorgeatgu jorgeatgu commented May 8, 2023

🎩 What? Why?

This PR implements the redesign in sortitions module:

Closes #10849

♥️ Thank you!

@jorgeatgu jorgeatgu added the project: redesign Barcelona City Council contract label May 8, 2023
@jorgeatgu jorgeatgu requested review from ferblape and furilo May 12, 2023 11:41
@jorgeatgu jorgeatgu marked this pull request as ready for review May 12, 2023 11:42
@entantoencuanto entantoencuanto force-pushed the feature/redesign-sortitions branch from fd2d409 to 10b2d66 Compare May 18, 2023 13:40
@furilo furilo requested a review from a team May 26, 2023 12:22
@furilo
Copy link
Copy Markdown
Contributor

furilo commented May 26, 2023

You can start reviewing this, @decidim/product

Copy link
Copy Markdown
Contributor

@ferblape ferblape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to me!

jorgeatgu and others added 3 commits May 26, 2023 15:47
* feature/redesign:
  Redesign: amendments (#10765)
  Redesign: proposals (#10555)
  Remove unused preset-env dependencies (#10916)
  Feature/redesign components breadcrumb (#10441)
  Redesign: debates (#10653)
  Redesign: Remove reference to commentable in activity cell (#10816)
  Redesign: spinner (#10848)
  Redesign: omnipresent banner (#10847)
  Add redesign enable ENV variable to control the pipeline (#10610)
  Redesign: progress bar (#10638)
  Redesign: meeting cards (#10722)
  Redesign: pending login (#10699)
Copy link
Copy Markdown
Member

@NilHomedes NilHomedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

Just to take in account that we need to refactor the space between elements, as it's said in #10869

@furilo furilo requested a review from alecslupu June 6, 2023 09:01
@alecslupu
Copy link
Copy Markdown
Contributor

Clicking on More information / Close nothing happens

image

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Identified a very small issue on the announcement, that not seems to be related with the sortition scope.

@ferblape ferblape merged commit bc3c1e5 into feature/redesign Jun 7, 2023
@ferblape ferblape deleted the feature/redesign-sortitions branch June 7, 2023 08:35
entantoencuanto added a commit that referenced this pull request Jun 8, 2023
* feature/redesign: (70 commits)
  Fix failing specs
  Redesign sortitions (#10831)
  Redesign: data toggle (#10886)
  Redesign: collaborative drafts (#10729)
  Redesign: pending pages (#10944)
  Redesign: my account (#10904)
  use foundation classes instead of default html validation (#10921)
  Fix failings redesign specs
  Add gitpod support (#10641)
  Fix pipeline after #10409 (#10670)
  Upgrade webpack and other javascript libraries (#10643)
  New Crowdin updates (#10409)
  Refactor attachment title (#10103)
  Fix for exporting hidden moderated proposals (#10630)
  Fix Exception as admin on a Proposal with meeting author (#10628)
  Fix: Deleted and hidden comments are exported (#10629)
  Rename "terms and conditions" to "terms of service" (#10614)
  Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606)
  Standardize the format of the words "they will" (#10617)
  Fix the spec after word standardization (#10624)
  ...
entantoencuanto added a commit that referenced this pull request Jun 12, 2023
…blies-details-page

* feature/redesign: (71 commits)
  Unskip tests (#10951)
  Fix failing specs
  Redesign sortitions (#10831)
  Redesign: data toggle (#10886)
  Redesign: collaborative drafts (#10729)
  Redesign: pending pages (#10944)
  Redesign: my account (#10904)
  use foundation classes instead of default html validation (#10921)
  Fix failings redesign specs
  Add gitpod support (#10641)
  Fix pipeline after #10409 (#10670)
  Upgrade webpack and other javascript libraries (#10643)
  New Crowdin updates (#10409)
  Refactor attachment title (#10103)
  Fix for exporting hidden moderated proposals (#10630)
  Fix Exception as admin on a Proposal with meeting author (#10628)
  Fix: Deleted and hidden comments are exported (#10629)
  Rename "terms and conditions" to "terms of service" (#10614)
  Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606)
  Standardize the format of the words "they will" (#10617)
  ...
entantoencuanto added a commit that referenced this pull request Jun 15, 2023
…ations

* feature/redesign: (78 commits)
  Redesign: initiatives (#10646)
  Redesign: surveys (#10922)
  Redesign: coauthors (#10954)
  remove font-bold from breadcrumb (#10990)
  Redesign: participatory texts (#10941)
  Redesign: budgets (#10195)
  Redesign: fix buttons & geocoder (#10975)
  Unskip tests (#10951)
  Fix failing specs
  Redesign sortitions (#10831)
  Redesign: data toggle (#10886)
  Redesign: collaborative drafts (#10729)
  Redesign: pending pages (#10944)
  Redesign: my account (#10904)
  use foundation classes instead of default html validation (#10921)
  Fix failings redesign specs
  Add gitpod support (#10641)
  Fix pipeline after #10409 (#10670)
  Upgrade webpack and other javascript libraries (#10643)
  New Crowdin updates (#10409)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants