Remove unused preset-env dependencies by alecslupu · Pull Request #10916 · decidim/decidim

alecslupu · 2023-05-26T16:21:36Z

🎩 What? Why?

While working on #10727 i have noticed the pipeline failed, due to some babel configuration as per below stacktrace:

Since @babel/preset-env has been updated to 7.22.0, it has removed the dependency to @babel/plugin-proposal-private-property-in-object.

Since I have added @babel/plugin-proposal-private-property-in-object, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-class-properties back in #8670, and I do not remember why, i am removing it in the current PR.

Testing

Make sure the pipeline is green.

♥️ Thank you!

andreslucena · 2023-05-29T06:07:25Z

@alecslupu I'm not able to reproduce the error locally by following the instructions, but just seeing the changes (and specially the pipeline result 😄) it wouldn't hurt. I had just two doubts:

In the plugins' doc page it says:

NOTE: This plugin is included in @babel/preset-env, in ES2022

So, I understand that we could remove it altogether from our configuration if we update @babel/preset-env?

I've seen that this rule was introduced on Update npm dependencies #8670, but as far as I remember we are not using this new syntax. Do you remember/know why we introduced this babel plugin?

andreslucena · 2023-05-29T06:09:50Z

FYI, I've removed the unfilled section from the PR template

alecslupu · 2023-05-29T06:15:59Z

@alecslupu I'm not able to reproduce the error locally by following the instructions, but just seeing the changes (and specially the pipeline result smile) it wouldn't hurt. I had just two doubts:
1. In the [plugins' doc page](https://babeljs.io/docs/babel-plugin-transform-private-property-in-object) it says:
NOTE: This plugin is included in @babel/preset-env, in ES2022

So, I understand that we could remove it altogether from our configuration if we update @babel/preset-env?
2. I've seen that this rule was introduced on [Update npm dependencies #8670](https://github.com/decidim/decidim/pull/8670), but as far as I remember we are not using this new syntax. Do you remember/know why we introduced this babel plugin?

I would say that if we upgrade the preset env maybe we will fix this issue. I would not try to do it in this PR, as it is currently blocking all the dev activities, and i see a potential of having unforeseen issues ...
I do not remember why i have added that. If i remember right, January 2022 was around a rails upgrade.

alecslupu · 2023-05-29T06:36:56Z

I confirm that if we upgrade the preset env and we remove that config entry, the compilation process is successful.

…-object

ahukkanen

I tested this approach in another repository where we had the same issue and it seems to have fixed the problem.

Also, I can see that the pipeline is green in this PR so it should be fine to merge.

I would like to have some kind of guidance also for implementors and module developers facing this issue once we can release the next versions, as it will take some time from now as we just released. But I am unsure what would be the correct place for such documentation, a GitHub issue maybe?

Anyways, regarding this PR, everything seems to be fine.

andreslucena

LGTM 👍🏽

ahukkanen · 2023-05-29T08:43:19Z

@andreslucena I'll leave the final merge for you since you were already looking into this. Just to add some confirmation to the issue that this seems to be fixing the problem.

andreslucena · 2023-05-29T08:44:09Z

I would like to have some kind of guidance also for implementors and module developers facing this issue once we can release the next versions, as it will take some time from now as we just released. But I am unsure what would be the correct place for such documentation, a GitHub issue maybe?

Yes, a GH issue seems to be the place, probably referencing this PR

ahukkanen · 2023-05-29T08:50:53Z

Yes, a GH issue seems to be the place, probably referencing this PR

Created #10918 explaining the workaround.

Feel free to edit if it is not clear enough.

* Remove unneeded dependency @babel/plugin-proposal-private-property-in-object * Remove unneeded dependency @babel/plugin-proposal-private-methods * Remove unneeded dependency @babel/plugin-proposal-class-properties

* feature/redesign: Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441)

* feature/redesign: Remove unused preset-env dependencies (#10916)

…rafts * feature/redesign: Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916)

* feature/redesign: Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916)

* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916)

…blies-details-page * feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610)

* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916)

* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610)

* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699)

* Remove unneeded dependency @babel/plugin-proposal-private-property-in-object * Remove unneeded dependency @babel/plugin-proposal-private-methods * Remove unneeded dependency @babel/plugin-proposal-class-properties

andreslucena · 2023-06-14T09:33:04Z

@alecslupu should we backport this one to v0.26 too?

andreslucena · 2023-06-14T09:35:47Z

@alecslupu should we backport this one to v0.26 too?

Oh never mind, I see that we don't have this configuration there:

https://github.com/decidim/decidim/blob/release/0.26-stable/babel.config.json

alecslupu added dependencies Pull requests that update a dependency file or issues that talk about updating dependencies javascript Pull requests that update Javascript code type: fix PRs that implement a fix for a bug labels May 26, 2023

alecslupu requested a review from a team May 26, 2023 16:24

alecslupu marked this pull request as ready for review May 26, 2023 17:49

andreslucena mentioned this pull request May 29, 2023

Show message on the Election form about the Organization time zone #10902

Merged

Remove unneeded dependency @babel/plugin-proposal-private-property-in…

db1ab2e

…-object

alecslupu force-pushed the fix/babel-preset-env branch from 34bc4db to db1ab2e Compare May 29, 2023 06:41

alecslupu added 2 commits May 29, 2023 09:46

Remove unneeded dependency @babel/plugin-proposal-private-methods

5bd7620

Remove unneeded dependency @babel/plugin-proposal-class-properties

f236032

alecslupu changed the title ~~Lock @babel/preset-env and @babel/core~~ Remove unused preset-env dependencies May 29, 2023

ahukkanen approved these changes May 29, 2023

View reviewed changes

andreslucena approved these changes May 29, 2023

View reviewed changes

andreslucena merged commit 67c2631 into develop May 29, 2023

andreslucena deleted the fix/babel-preset-env branch May 29, 2023 08:43

ahukkanen mentioned this pull request May 29, 2023

Asset compilation fails due to newer babel versions (Cannot find package) #10918

Closed

andreslucena mentioned this pull request May 29, 2023

Fix flaky searching specs #10909

Merged

alecslupu mentioned this pull request May 29, 2023

Redesign: proposals #10555

Merged

entantoencuanto added a commit that referenced this pull request May 29, 2023

Merge branch 'feature/redesign' into feature/redesign-proposals

109a542

* feature/redesign: Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441)

entantoencuanto added a commit that referenced this pull request May 29, 2023

Merge branch 'feature/redesign' into feature/redesign-amendments

3f4d108

* feature/redesign: Remove unused preset-env dependencies (#10916)

entantoencuanto added a commit that referenced this pull request May 30, 2023

Merge branch 'feature/redesign' into feature/redesign-collaborative-d…

13341b9

…rafts * feature/redesign: Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916)

entantoencuanto added a commit that referenced this pull request May 30, 2023

Merge branch 'feature/redesign' into feature/redesign-staging

fb24537

* feature/redesign: Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916)

entantoencuanto added a commit that referenced this pull request Jun 2, 2023

Merge branch 'feature/redesign' into feature/redesign-forms

6a912f7

* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916)

entantoencuanto added a commit that referenced this pull request Jun 2, 2023

Merge branch 'feature/redesign' into feature/redesign-initiatives

8b2c970

* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916)

entantoencuanto added a commit that referenced this pull request Jun 2, 2023

Merge branch 'feature/redesign' into feature/redesign-home

17850a5

* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916)

armandfardeau mentioned this pull request Jun 13, 2023

Remove unused preset-env dependencies (#10916) #10997

Closed

andreslucena mentioned this pull request Jun 14, 2023

Add a button to send a newsletter to the admin #10896

Merged

alecslupu mentioned this pull request Jun 14, 2023

Backport 'Remove unused preset-env dependencies' to v0.27 #11005

Merged

alecslupu mentioned this pull request Jun 15, 2023

Error with @babel/plugin-proposal-private-methods #10993

Closed

fblupi mentioned this pull request Jun 27, 2023

Add babel config and update README.md Platoniq/decidim-module-alternative_landing#40

Merged

alecslupu mentioned this pull request Jul 19, 2023

Analize the PRs in the last year to consider new backports. #11233

Closed

fblupi mentioned this pull request Jul 25, 2023

Upgrade to decidim 0.27.4 SomComuns/decidim-bcnencomu#98

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove unused preset-env dependencies#10916

Remove unused preset-env dependencies#10916
andreslucena merged 3 commits intodevelopfrom
fix/babel-preset-env

alecslupu commented May 26, 2023 •

edited

Loading

Uh oh!

andreslucena commented May 29, 2023

Uh oh!

andreslucena commented May 29, 2023

Uh oh!

alecslupu commented May 29, 2023

Uh oh!

alecslupu commented May 29, 2023

Uh oh!

ahukkanen left a comment

Uh oh!

andreslucena left a comment

Uh oh!

ahukkanen commented May 29, 2023

Uh oh!

andreslucena commented May 29, 2023

Uh oh!

ahukkanen commented May 29, 2023

Uh oh!

andreslucena commented Jun 14, 2023

Uh oh!

andreslucena commented Jun 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

alecslupu commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

Testing

Uh oh!

andreslucena commented May 29, 2023

Uh oh!

andreslucena commented May 29, 2023

Uh oh!

alecslupu commented May 29, 2023

Uh oh!

alecslupu commented May 29, 2023

Uh oh!

ahukkanen left a comment

Choose a reason for hiding this comment

Uh oh!

andreslucena left a comment

Choose a reason for hiding this comment

Uh oh!

ahukkanen commented May 29, 2023

Uh oh!

andreslucena commented May 29, 2023

Uh oh!

ahukkanen commented May 29, 2023

Uh oh!

andreslucena commented Jun 14, 2023

Uh oh!

andreslucena commented Jun 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alecslupu commented May 26, 2023 •

edited

Loading