Merged
Conversation
3 tasks
alecslupu
approved these changes
May 16, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
The code looks ok. I would still want to test it locally
Contributor
|
We are going to merge this soon so we can continue. |
Contributor
|
While reviewing the debates module i have noticed that the announcement background is ending mid screen.
|
Contributor
|
When clicking to create a new debate from the public interface, the validations are being triggered when loading the page, without any interaction with the form itself. Edit: I get similar behavior for Comments on Blog, so this is not a Debates specific issue. |
Contributor
|
When formatting close debate text, i get a very strange formatting.
|
Contributor
|
@entantoencuanto I have reviewed the debates module and i could not find anything that stands out from functionality point of view. |
98704fa to
b568b89
Compare
entantoencuanto
added a commit
that referenced
this pull request
May 26, 2023
entantoencuanto
added a commit
that referenced
this pull request
May 26, 2023
…rafts * feature/redesign: Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699) simplify 2col layout (#10819) Redesign: processes groups content blocks (#10491) Redesign: assemblies content blocks (#10573)
entantoencuanto
added a commit
that referenced
this pull request
May 26, 2023
* feature/redesign: (21 commits) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699) simplify 2col layout (#10819) Redesign: processes groups content blocks (#10491) Redesign: assemblies content blocks (#10573) Redesign: process & process group cards (#10716) Redesign: conference cards (#10502) Redesign: pending blogs (#10686) Redesign: blog cards (#10685) Redesign: filters (#10390) replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) ...
entantoencuanto
added a commit
that referenced
this pull request
Jun 2, 2023
…blies-details-page * feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610)
entantoencuanto
added a commit
that referenced
this pull request
Jun 2, 2023
* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610)
entantoencuanto
added a commit
that referenced
this pull request
Jun 2, 2023
* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699)
entantoencuanto
added a commit
that referenced
this pull request
Jun 2, 2023
* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR uses the same branch that #10183, which was merged into feature/redesign by mistake. That merge was reverted but GitHub closed the PR and marked as merged.
📷 Screenshots
Please add screenshots of the changes you're proposing
Pending