Merged
Conversation
filter_scopes_values_from and scope_children_to_tree methods use a participatory_space argument, nil by default. the resource_filter_scope_values and filter_scopes_values methods pass current_participatory_space calling these methods
…rticipatory space
12 tasks
This class is used by js to identify filters
* feature/redesign: (183 commits) include a clause to change a data-attr on the fly Update tests Restore specs set different modals foreach comment unify report button for futher uses use report_button instead of flag_modal Unify comments:loaded event Remove pending Skip unless redesign enabled Remove turbo reference Remove unused method Remove unused components Disabled examples when redesign is disabled Fix edit comment after comment edited use label component clean duplicated class replace div with button and remove tabindex add type="button" to opinion buttons to avoid the form submit when clicking on them remove a[href*=/users/sign_] styles remove profile and cell author ...
Contributor
|
@decidim/product this would be ready, right? |
NilHomedes
approved these changes
Mar 28, 2023
Member
NilHomedes
left a comment
There was a problem hiding this comment.
Looks good to me now, thanks!
furilo
approved these changes
Mar 28, 2023
alecslupu
suggested changes
Apr 3, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
I could verify the PR, and seems to be working as it should, based on the testing i have performed.
There are a few changes that are required before merging this PR.
- Let's avoid using meetings translations keys in ParticipatoryProcesses.
- A reference on #10376, which has already been merged.
- a confirmation, that we need a certain
aria-controlsvalue - Some tests that are skipped as the developer considered it obsolete.
Thank you for your work.
...patory_processes/app/helpers/decidim/participatory_processes/participatory_process_helper.rb
Outdated
Show resolved
Hide resolved
decidim-participatory_processes/spec/system/filter_participatory_processes_spec.rb
Outdated
Show resolved
Hide resolved
decidim-participatory_processes/spec/system/filter_participatory_processes_spec.rb
Outdated
Show resolved
Hide resolved
* feature/redesign: replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547)
ferblape
approved these changes
Apr 17, 2023
Contributor
|
We've implemented all the feedback provided by Alex. We are merging it because there are a few PRs that need this to be completed. |
entantoencuanto
added a commit
that referenced
this pull request
Apr 18, 2023
* feature/redesign: Redesign: filters (#10390)
entantoencuanto
added a commit
that referenced
this pull request
Apr 21, 2023
…content-blocks * feature/redesign: Redesign: filters (#10390)
entantoencuanto
added a commit
that referenced
this pull request
Apr 28, 2023
…ent-blocks * feature/redesign: (196 commits) Redesign: process & process group cards (#10716) Redesign: conference cards (#10502) Redesign: pending blogs (#10686) Redesign: blog cards (#10685) Redesign: filters (#10390) replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547) include a clause to change a data-attr on the fly Update tests Restore specs set different modals foreach comment unify report button for futher uses use report_button instead of flag_modal Unify comments:loaded event ...
entantoencuanto
added a commit
that referenced
this pull request
May 26, 2023
* feature/redesign: (21 commits) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699) simplify 2col layout (#10819) Redesign: processes groups content blocks (#10491) Redesign: assemblies content blocks (#10573) Redesign: process & process group cards (#10716) Redesign: conference cards (#10502) Redesign: pending blogs (#10686) Redesign: blog cards (#10685) Redesign: filters (#10390) replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) ...
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Changes in design of filters:
search_variable: If provided a block to search is includedfilter_sections: an array of hashes. Each of them serves to define a filter section and its content is passed as arguments to acollection_filterhelper function📌 Related Issues
Testing
The redesigned filters are currently working on: