Conversation
There was a problem hiding this comment.
Yay, we already have the mobile menu! Some minor details to adjust:
-
On the search page the menu overlaps with the navigation buttons (doesn't happen on the rest of the pages).
-
When scrolling to the end, the menu overlaps part of the footer.
-
The search page should first display the search input and then the filters. #10625
-
All in all, the links work correctly but I noticed a behavior in the search that we should change now that we will have a direct access from the menu: Clicking on "Search" returns the search " ". We had not designed this page in mobile, but my expectation is to find the search input without results by default. To not block this PR, we can open an issue with this specific task. #10626
2979ba3 to
dace8a7
Compare
I wasn't able to reproduce it, neither desktop debugging nor my mobile phone. In any case, it you only notice that in the search page, it's more likely a problem of the cards (i.e the search results) than the menu-header itself
Just for the record, I've applied a margin-bottom for mobile devices, but there's stuff not integrated yet, and these things appears at the bottom of the page, giving you a fake feeling of overlapping. Some pages as the homepage or the last_activities have no content like that, so you can see the menu is placed roperly. In the meanwhile, we cannot fully solve that issue. |
Since we're using a two columns layout, that's far from straightforward. I'll create an issue as it requires to alter such layout to order the elements as you say (even though the a11y is penalised, https://css-tricks.com/grid-content-re-ordering-and-accessibility/). For the time being, is out of the scope of this PR. |
|
@decidim/product could you check this again? |
carolromero
left a comment
There was a problem hiding this comment.
Re-reviewed and 👌, thanks @Crashillo!
There was a problem hiding this comment.
While reviewing the PR, i have noticed there are 2 reveal (Confirm + Data picker) divs that are visible at the end of the document. Can you, please, investigate further the issue?
Divs removed from inspector:
Changed the lanscape:
IPAD simulation:
* feature/redesign: Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547)
* feature/redesign: replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547)
…ent-blocks * feature/redesign: (196 commits) Redesign: process & process group cards (#10716) Redesign: conference cards (#10502) Redesign: pending blogs (#10686) Redesign: blog cards (#10685) Redesign: filters (#10390) replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547) include a clause to change a data-attr on the fly Update tests Restore specs set different modals foreach comment unify report button for futher uses use report_button instead of flag_modal Unify comments:loaded event ...
* feature/redesign: (21 commits) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699) simplify 2col layout (#10819) Redesign: processes groups content blocks (#10491) Redesign: assemblies content blocks (#10573) Redesign: process & process group cards (#10716) Redesign: conference cards (#10502) Redesign: pending blogs (#10686) Redesign: blog cards (#10685) Redesign: filters (#10390) replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) ...
🎩 What? Why?
Integrate the links inside the bottom bar in mobile view
📷 Screenshots