Merged
Conversation
ferblape
reviewed
Apr 11, 2023
9cc68fe to
4f26d41
Compare
ferblape
approved these changes
Apr 13, 2023
Merged
Contributor
|
@decidim/product I would do some slight design adjustments regarding elements spacing mainly, but I think we can wait to the "small design details cycle" ;) and meanwhile merge this. |
furilo
approved these changes
Apr 14, 2023
carolromero
requested changes
Apr 17, 2023
Member
There was a problem hiding this comment.
Hi! Here's feedback from the product review:
- According to the original design we show 3 lines of text. Also this way the posts can keep the same height, regardless of whether they have an image or not
(FWIW on mobile the first 3 lines of text are displayed)
- Post sorting options are missing
- Missing design for posts with images on mobile
Contributor
Author
Currently, there are no sorting options in the blog lists: https://decidim.populate.tools/processes/wear-exaggerate/f/9/, feel free to open a new issue if you wanna include this new feature |
alecslupu
reviewed
Apr 20, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
I have read through the code, and I could not find anything "strange". Pending testing on my local host.
alecslupu
approved these changes
Apr 24, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
I cannot tell i like the way the image is being shown, but codewise we are ok.
entantoencuanto
added a commit
that referenced
this pull request
Apr 25, 2023
entantoencuanto
added a commit
that referenced
this pull request
Apr 28, 2023
…ent-blocks * feature/redesign: (196 commits) Redesign: process & process group cards (#10716) Redesign: conference cards (#10502) Redesign: pending blogs (#10686) Redesign: blog cards (#10685) Redesign: filters (#10390) replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547) include a clause to change a data-attr on the fly Update tests Restore specs set different modals foreach comment unify report button for futher uses use report_button instead of flag_modal Unify comments:loaded event ...
entantoencuanto
added a commit
that referenced
this pull request
May 4, 2023
entantoencuanto
added a commit
that referenced
this pull request
May 4, 2023
entantoencuanto
added a commit
that referenced
this pull request
May 26, 2023
* feature/redesign: (21 commits) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699) simplify 2col layout (#10819) Redesign: processes groups content blocks (#10491) Redesign: assemblies content blocks (#10573) Redesign: process & process group cards (#10716) Redesign: conference cards (#10502) Redesign: pending blogs (#10686) Redesign: blog cards (#10685) Redesign: filters (#10390) replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Integrate the new cards on the blog list, remove mocked component and solve the pending issues.
📌 Related Issues
📷 Screenshots
https://decidim-redesign.populate.tools/processes/smile-cutting/f/19/