Redesign: card L link whole card#10554
Merged
ferblape merged 8 commits intofeature/redesignfrom Mar 27, 2023
Merged
Conversation
120f380 to
981769e
Compare
Contributor
|
@entantoencuanto could you review the broken test https://github.com/decidim/decidim/actions/runs/4420644015/jobs/7750595065?pr=10554 ?? |
Contributor
|
@decidim/product this is something mostly technical, but you may want to take a look. |
ferblape
approved these changes
Mar 22, 2023
…le-card * feature/redesign: (94 commits) Fix test Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) Fix destroying scope types that have been associated with processes (#10496) Fix dynamic upload file field required indicator + make option naming consistent (#10497) Standardize the format of the words "should not" (#10515) Standardize the format of the words "were not" (#10516) ...
carolromero
approved these changes
Mar 23, 2023
Contributor
|
All yours @decidim/maintainers |
…le-card * feature/redesign: (183 commits) include a clause to change a data-attr on the fly Update tests Restore specs set different modals foreach comment unify report button for futher uses use report_button instead of flag_modal Unify comments:loaded event Remove pending Skip unless redesign enabled Remove turbo reference Remove unused method Remove unused components Disabled examples when redesign is disabled Fix edit comment after comment edited use label component clean duplicated class replace div with button and remove tabindex add type="button" to opinion buttons to avoid the form submit when clicking on them remove a[href*=/users/sign_] styles remove profile and cell author ...
Contributor
Author
Already fixed |
alecslupu
approved these changes
Mar 27, 2023
entantoencuanto
added a commit
that referenced
this pull request
Mar 29, 2023
…content-blocks * feature/redesign: (187 commits) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547) include a clause to change a data-attr on the fly Update tests Restore specs set different modals foreach comment unify report button for futher uses use report_button instead of flag_modal Unify comments:loaded event Remove pending Skip unless redesign enabled Remove turbo reference Remove unused method Remove unused components Disabled examples when redesign is disabled Fix edit comment after comment edited use label component clean duplicated class ...
entantoencuanto
added a commit
that referenced
this pull request
Apr 10, 2023
* feature/redesign: Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547)
entantoencuanto
added a commit
that referenced
this pull request
Apr 13, 2023
* feature/redesign: replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547)
entantoencuanto
added a commit
that referenced
this pull request
Apr 28, 2023
…ent-blocks * feature/redesign: (196 commits) Redesign: process & process group cards (#10716) Redesign: conference cards (#10502) Redesign: pending blogs (#10686) Redesign: blog cards (#10685) Redesign: filters (#10390) replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547) include a clause to change a data-attr on the fly Update tests Restore specs set different modals foreach comment unify report button for futher uses use report_button instead of flag_modal Unify comments:loaded event ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR:
link_whole_card: trueoption on calls to card-l, since it's now the default.link_whole_card: falseto wrap the title, description and metadata with the link if presentlink_whole_cardThis PR is useful in budgets, where an extra data block with actions is shown with the card
To test it you should check the cards have a link at https://decidim-redesign.populate.tools/cards_debug#Decidim::Proposals::Proposal
📌 Related Issues
Testing
Describe the best way to test or validate your PR.
📷 Screenshots
Please add screenshots of the changes you're proposing
