Skip to content

Make buttons respect the organizations' primary color#10526

Merged
alecslupu merged 1 commit intodevelopfrom
fix/copy-button-primary-color
Mar 14, 2023
Merged

Make buttons respect the organizations' primary color#10526
alecslupu merged 1 commit intodevelopfrom
fix/copy-button-primary-color

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

The copy button on the share modal doesn't respect the "Primary" color configuration of the Organization appeareance.

This PR fixes that.

Testing

  1. Sign in as admin
  2. Change the Primary color in the Organization's Appeareance form
  3. Go to a resource shareable (for instance a Participatory Process)
  4. Click on the "Share" link
  5. Click on "Share link" button
  6. See that the "Copy" button has the default primary color

📷 Screenshots

Before

Selection_567

After

Selection_566

♥️ Thank you!

andreslucena added a commit to decidim-vocdoni/decidim-module-vocdoni that referenced this pull request Mar 13, 2023
There's a bug on Decidim related with the Copy button on Share modal.
I proposed a fix and when that's accepted, backported and released,
we can remove this rule.

The fix is proposed on decidim/decidim#10526
andreslucena added a commit to decidim-vocdoni/decidim-module-vocdoni that referenced this pull request Mar 13, 2023
There's a bug on Decidim related with the Copy button on Share modal.
I proposed a fix and when that's accepted, backported and released,
we can remove this rule.

The fix is proposed on decidim/decidim#10526
@ahukkanen ahukkanen added type: fix PRs that implement a fix for a bug module: core labels Mar 13, 2023
@alecslupu alecslupu requested a review from a team March 14, 2023 09:18
@alecslupu alecslupu merged commit 1548f10 into develop Mar 14, 2023
@alecslupu alecslupu deleted the fix/copy-button-primary-color branch March 14, 2023 09:19
andreslucena added a commit to decidim-vocdoni/decidim-module-vocdoni that referenced this pull request Mar 20, 2023
There's a bug on Decidim related with the Copy button on Share modal.
I proposed a fix and when that's accepted, backported and released,
we can remove this rule.

The fix is proposed on decidim/decidim#10526
microstudi added a commit to decidim-vocdoni/decidim-module-vocdoni that referenced this pull request Mar 21, 2023
* Add HTML titles to admin pages

* Use Decidim::Vocdoni.config for accessing module configuration

* Add interruptible setting on Election

This setting configures on the Vocdoni API if the election can be
paused, canceled or ended before the end_time.
In case it was paused, it can be continued.
Canceled and ended are irreversible.

* Add visual feebaack (spinner) while doing AJAX operations

* Change "available credits" logic

While developing the `interruptible` feature, I've seen that the current
approach didn't fully worked, as we actually need to use credits while
doing these actions (cancel, pause, end, and continue). This means that
I needed to show the "available credits" on multiple pages, and also use
the .collectFaucetTokens when doing those actions.

As this is the Vocdoni monetization strategy, I think its better to make
this action explicit, even on development/staging, so administrators are
aware of this future expense.

* Add "canceled" and "paused" status on Election

* Add "interruptible" logic

If this checkbox is enabled, then we show a "Danger zone" in the
admin panel once the Election is in the "vote" step. This allows the
admin to:

* Cancel an election: doesn't publish the results
* End an election: publish the results. It's the same result as if the
  election has reached the configured end_time.
* Pause an election: momentarily doesn't accept votes

* Show a message when logging if the election is paused

* Run i18n-tasks normalize

* Handle canceled/paused elections voting frontend

* Add verbosity and quiet argument to :change_election_status task

* Fix CSS for questions previews' accordions

* Make elections frontend aware of "canceled" and "paused" status

* Fix bug when trying to get the Votes and there isn't any Election

* Fix bug when checking the ElectionStatus while login

* Fix bug when passing the Wallet for voting

* Run i18n-tasks normalize

* Fix typo

* Always create a new wallet on Steps spec

* Change default Vocodni API endpoint to staging

* Make the Census email case insensitive

* Prefer usage of `env` over `vocdoniEnv` in JS variable names

* Fix hardcoding Explorer Vote dev environment URL on 'vote verify'

* Fix accordion CSS on vote stats and results

* Fix bug while publishing results

* Show styles (e.g. line breaks) on Election description

* Fix permission when election has finished prematurely (canceled or manually ended)

* Fix bug on focus mode when changing the Organizations' primary color

* Fix external link indicator icon in Vocodni logo

* Fix bug on `Copy` button when changing the Organizations' primary color

There's a bug on Decidim related with the Copy button on Share modal.
I proposed a fix and when that's accepted, backported and released,
we can remove this rule.

The fix is proposed on decidim/decidim#10526

* Change copies on 'Vote successfully casted' page

* Add more specs and improve the ongoing/finished methods on Elections

* Make the 'answers values' set-up transparent to Admins

As it's an implementation detail, it doesn't make much sense to have it
an an explicit option during the Election Setup Step.

We do it with AJAX just before the Setup.

* Fix eslint offenses

* Add error details when Election Setup failed

* Remove 'Available credits' expectation in system spec

* Improve error logging during Setup Election step

* Fix Setup Election spec by waiting for the account to be created in the API

* Undo rubocop change on Election status changer task output

* fix codecov

* Drop quiet argument from change_election_status task

Suggested by code review. It's not necessary as we can redirect output
to /dev/null on the crontab. (> /dev/null)

* Get the answers_values_election_path from a data attribute.

Suggested by code review. It's much more cleaner and less buggy.

* Fix erblint offense

---------

Co-authored-by: Ivan Vergés <ivan@pokecode.net>
entantoencuanto added a commit that referenced this pull request Mar 23, 2023
…ent-blocks

* feature/redesign: (97 commits)
  Feature/redesign accountability versions (#10517)
  Redesign: add image to blog item (#10458)
  Redesign: search results (#10380)
  Fix test
  Finalize word standardization (#10557)
  Fix iframes stripped from admin entered proposals, meetings and debates (#10466)
  Fix ImageMagick errors when trying to identify image dimensions (#10343)
  Add required to proposal limit field in Proposal component (#10525)
  Standardize the format of the words "is not" (#10511)
  Standardize the format of the words "has not" (#10510)
  Standardize the format of the words "will not" (#10509)
  Make buttons respect the organizations' primary color (#10526)
  Fix flaky spec for questionnaire templates (#10544)
  Remove the deprecated `optional` option from the file upload modal (#10542)
  Standardize the format of the words "does not" (#10505)
  Standardize the format of the words "was not" (#10514)
  Add Procfile support (#10519)
  Standardize the format of the words "do not" (#10513)
  Change the `optional` option to `required` at participatory texts (#10498)
  Fix destroying scope types that have been associated with processes (#10496)
  ...
entantoencuanto added a commit that referenced this pull request Mar 23, 2023
…le-card

* feature/redesign: (94 commits)
  Fix test
  Finalize word standardization (#10557)
  Fix iframes stripped from admin entered proposals, meetings and debates (#10466)
  Fix ImageMagick errors when trying to identify image dimensions (#10343)
  Add required to proposal limit field in Proposal component (#10525)
  Standardize the format of the words "is not" (#10511)
  Standardize the format of the words "has not" (#10510)
  Standardize the format of the words "will not" (#10509)
  Make buttons respect the organizations' primary color (#10526)
  Fix flaky spec for questionnaire templates (#10544)
  Remove the deprecated `optional` option from the file upload modal (#10542)
  Standardize the format of the words "does not" (#10505)
  Standardize the format of the words "was not" (#10514)
  Add Procfile support (#10519)
  Standardize the format of the words "do not" (#10513)
  Change the `optional` option to `required` at participatory texts (#10498)
  Fix destroying scope types that have been associated with processes (#10496)
  Fix dynamic upload file field required indicator + make option naming consistent (#10497)
  Standardize the format of the words "should not" (#10515)
  Standardize the format of the words "were not" (#10516)
  ...
entantoencuanto added a commit that referenced this pull request Mar 23, 2023
* feature/redesign: (99 commits)
  Feature/redesign accountability versions (#10517)
  Redesign: add image to blog item (#10458)
  Redesign: search results (#10380)
  Fix test
  Redesign: layout item (#10376)
  Feature/redesign order filter (#10563)
  Finalize word standardization (#10557)
  Fix iframes stripped from admin entered proposals, meetings and debates (#10466)
  Fix ImageMagick errors when trying to identify image dimensions (#10343)
  Add required to proposal limit field in Proposal component (#10525)
  Standardize the format of the words "is not" (#10511)
  Standardize the format of the words "has not" (#10510)
  Standardize the format of the words "will not" (#10509)
  Make buttons respect the organizations' primary color (#10526)
  Fix flaky spec for questionnaire templates (#10544)
  Remove the deprecated `optional` option from the file upload modal (#10542)
  Standardize the format of the words "does not" (#10505)
  Standardize the format of the words "was not" (#10514)
  Add Procfile support (#10519)
  Standardize the format of the words "do not" (#10513)
  ...
entantoencuanto added a commit that referenced this pull request Mar 23, 2023
* feature/redesign: (94 commits)
  Fix test
  Finalize word standardization (#10557)
  Fix iframes stripped from admin entered proposals, meetings and debates (#10466)
  Fix ImageMagick errors when trying to identify image dimensions (#10343)
  Add required to proposal limit field in Proposal component (#10525)
  Standardize the format of the words "is not" (#10511)
  Standardize the format of the words "has not" (#10510)
  Standardize the format of the words "will not" (#10509)
  Make buttons respect the organizations' primary color (#10526)
  Fix flaky spec for questionnaire templates (#10544)
  Remove the deprecated `optional` option from the file upload modal (#10542)
  Standardize the format of the words "does not" (#10505)
  Standardize the format of the words "was not" (#10514)
  Add Procfile support (#10519)
  Standardize the format of the words "do not" (#10513)
  Change the `optional` option to `required` at participatory texts (#10498)
  Fix destroying scope types that have been associated with processes (#10496)
  Fix dynamic upload file field required indicator + make option naming consistent (#10497)
  Standardize the format of the words "should not" (#10515)
  Standardize the format of the words "were not" (#10516)
  ...
entantoencuanto added a commit that referenced this pull request Mar 23, 2023
* feature/redesign: (98 commits)
  Feature/redesign accountability versions (#10517)
  Redesign: add image to blog item (#10458)
  Redesign: search results (#10380)
  Fix test
  Redesign: layout item (#10376)
  Finalize word standardization (#10557)
  Fix iframes stripped from admin entered proposals, meetings and debates (#10466)
  Fix ImageMagick errors when trying to identify image dimensions (#10343)
  Add required to proposal limit field in Proposal component (#10525)
  Standardize the format of the words "is not" (#10511)
  Standardize the format of the words "has not" (#10510)
  Standardize the format of the words "will not" (#10509)
  Make buttons respect the organizations' primary color (#10526)
  Fix flaky spec for questionnaire templates (#10544)
  Remove the deprecated `optional` option from the file upload modal (#10542)
  Standardize the format of the words "does not" (#10505)
  Standardize the format of the words "was not" (#10514)
  Add Procfile support (#10519)
  Standardize the format of the words "do not" (#10513)
  Change the `optional` option to `required` at participatory texts (#10498)
  ...
entantoencuanto added a commit that referenced this pull request Mar 23, 2023
* feature/redesign: (97 commits)
  Feature/redesign accountability versions (#10517)
  Redesign: add image to blog item (#10458)
  Redesign: search results (#10380)
  Fix test
  Finalize word standardization (#10557)
  Fix iframes stripped from admin entered proposals, meetings and debates (#10466)
  Fix ImageMagick errors when trying to identify image dimensions (#10343)
  Add required to proposal limit field in Proposal component (#10525)
  Standardize the format of the words "is not" (#10511)
  Standardize the format of the words "has not" (#10510)
  Standardize the format of the words "will not" (#10509)
  Make buttons respect the organizations' primary color (#10526)
  Fix flaky spec for questionnaire templates (#10544)
  Remove the deprecated `optional` option from the file upload modal (#10542)
  Standardize the format of the words "does not" (#10505)
  Standardize the format of the words "was not" (#10514)
  Add Procfile support (#10519)
  Standardize the format of the words "do not" (#10513)
  Change the `optional` option to `required` at participatory texts (#10498)
  Fix destroying scope types that have been associated with processes (#10496)
  ...
entantoencuanto added a commit that referenced this pull request Mar 23, 2023
…-l-g

* feature/redesign: (99 commits)
  Feature/redesign accountability versions (#10517)
  Redesign: add image to blog item (#10458)
  Redesign: search results (#10380)
  Fix test
  Redesign: layout item (#10376)
  Feature/redesign order filter (#10563)
  Finalize word standardization (#10557)
  Fix iframes stripped from admin entered proposals, meetings and debates (#10466)
  Fix ImageMagick errors when trying to identify image dimensions (#10343)
  Add required to proposal limit field in Proposal component (#10525)
  Standardize the format of the words "is not" (#10511)
  Standardize the format of the words "has not" (#10510)
  Standardize the format of the words "will not" (#10509)
  Make buttons respect the organizations' primary color (#10526)
  Fix flaky spec for questionnaire templates (#10544)
  Remove the deprecated `optional` option from the file upload modal (#10542)
  Standardize the format of the words "does not" (#10505)
  Standardize the format of the words "was not" (#10514)
  Add Procfile support (#10519)
  Standardize the format of the words "do not" (#10513)
  ...
entantoencuanto added a commit that referenced this pull request Mar 23, 2023
…content-blocks

* feature/redesign: (99 commits)
  Feature/redesign accountability versions (#10517)
  Redesign: add image to blog item (#10458)
  Redesign: search results (#10380)
  Fix test
  Redesign: layout item (#10376)
  Feature/redesign order filter (#10563)
  Finalize word standardization (#10557)
  Fix iframes stripped from admin entered proposals, meetings and debates (#10466)
  Fix ImageMagick errors when trying to identify image dimensions (#10343)
  Add required to proposal limit field in Proposal component (#10525)
  Standardize the format of the words "is not" (#10511)
  Standardize the format of the words "has not" (#10510)
  Standardize the format of the words "will not" (#10509)
  Make buttons respect the organizations' primary color (#10526)
  Fix flaky spec for questionnaire templates (#10544)
  Remove the deprecated `optional` option from the file upload modal (#10542)
  Standardize the format of the words "does not" (#10505)
  Standardize the format of the words "was not" (#10514)
  Add Procfile support (#10519)
  Standardize the format of the words "do not" (#10513)
  ...
entantoencuanto added a commit that referenced this pull request Mar 23, 2023
…s-l-g

* feature/redesign: (97 commits)
  Feature/redesign accountability versions (#10517)
  Redesign: add image to blog item (#10458)
  Redesign: search results (#10380)
  Fix test
  Finalize word standardization (#10557)
  Fix iframes stripped from admin entered proposals, meetings and debates (#10466)
  Fix ImageMagick errors when trying to identify image dimensions (#10343)
  Add required to proposal limit field in Proposal component (#10525)
  Standardize the format of the words "is not" (#10511)
  Standardize the format of the words "has not" (#10510)
  Standardize the format of the words "will not" (#10509)
  Make buttons respect the organizations' primary color (#10526)
  Fix flaky spec for questionnaire templates (#10544)
  Remove the deprecated `optional` option from the file upload modal (#10542)
  Standardize the format of the words "does not" (#10505)
  Standardize the format of the words "was not" (#10514)
  Add Procfile support (#10519)
  Standardize the format of the words "do not" (#10513)
  Change the `optional` option to `required` at participatory texts (#10498)
  Fix destroying scope types that have been associated with processes (#10496)
  ...
entantoencuanto added a commit that referenced this pull request Mar 23, 2023
* feature/redesign: (97 commits)
  Feature/redesign accountability versions (#10517)
  Redesign: add image to blog item (#10458)
  Redesign: search results (#10380)
  Fix test
  Finalize word standardization (#10557)
  Fix iframes stripped from admin entered proposals, meetings and debates (#10466)
  Fix ImageMagick errors when trying to identify image dimensions (#10343)
  Add required to proposal limit field in Proposal component (#10525)
  Standardize the format of the words "is not" (#10511)
  Standardize the format of the words "has not" (#10510)
  Standardize the format of the words "will not" (#10509)
  Make buttons respect the organizations' primary color (#10526)
  Fix flaky spec for questionnaire templates (#10544)
  Remove the deprecated `optional` option from the file upload modal (#10542)
  Standardize the format of the words "does not" (#10505)
  Standardize the format of the words "was not" (#10514)
  Add Procfile support (#10519)
  Standardize the format of the words "do not" (#10513)
  Change the `optional` option to `required` at participatory texts (#10498)
  Fix destroying scope types that have been associated with processes (#10496)
  ...
entantoencuanto added a commit that referenced this pull request Mar 24, 2023
…dcrumb

* feature/redesign: (282 commits)
  include a clause to change a data-attr on the fly
  Update tests
  Restore specs
  Feature/redesign accountability versions (#10517)
  set different modals foreach comment
  Redesign: add image to blog item (#10458)
  unify report button for futher uses
  Redesign: search results (#10380)
  Fix test
  Redesign: layout item (#10376)
  Feature/redesign order filter (#10563)
  Finalize word standardization (#10557)
  Fix iframes stripped from admin entered proposals, meetings and debates (#10466)
  Fix ImageMagick errors when trying to identify image dimensions (#10343)
  Add required to proposal limit field in Proposal component (#10525)
  Standardize the format of the words "is not" (#10511)
  Standardize the format of the words "has not" (#10510)
  Standardize the format of the words "will not" (#10509)
  Make buttons respect the organizations' primary color (#10526)
  Fix flaky spec for questionnaire templates (#10544)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants