Standardize the format of the words "should not"#10515
Merged
alecslupu merged 1 commit intodecidim:developfrom Mar 13, 2023
Merged
Standardize the format of the words "should not"#10515alecslupu merged 1 commit intodecidim:developfrom
alecslupu merged 1 commit intodecidim:developfrom
Conversation
alecslupu
approved these changes
Mar 10, 2023
This was referenced Mar 15, 2023
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
…le-card * feature/redesign: (94 commits) Fix test Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) Fix destroying scope types that have been associated with processes (#10496) Fix dynamic upload file field required indicator + make option naming consistent (#10497) Standardize the format of the words "should not" (#10515) Standardize the format of the words "were not" (#10516) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
* feature/redesign: (94 commits) Fix test Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) Fix destroying scope types that have been associated with processes (#10496) Fix dynamic upload file field required indicator + make option naming consistent (#10497) Standardize the format of the words "should not" (#10515) Standardize the format of the words "were not" (#10516) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
As a follow up for #10504, I am also suggesting to standardize the written format of "should not".
📌 Related Issues
Testing
Run the following command at the root of the repository:
Expect to see no matches.