Redesign: search results by Crashillo · Pull Request #10380 · decidim/decidim

Crashillo · 2023-02-13T17:36:33Z

🎩 What? Why?

Implements the search page, but only the scaffolding around, i.e. the layout and the result block wrapper (not the content, since these are individual Card-L items)

Caveats

The search results list a set of Card-L elements. Some of them are not yet integrated, therefore the current view looks like buggy, but that's not the PR purpose. The things to test here are:

The filter sidebar
The search input
The headings
The decorator between blocks

Pending

That the search query is correctly passed from the search box in the header
Include the areas/scope filters

📷 Screenshots

https://decidim-redesign.populate.tools/search

♥️ Thank you!

furilo · 2023-02-23T14:51:35Z

@decidim/product there are some technical details and integrations pending (the will be done in other PRs), but you can review the part that is integrated

decidim-core/app/views/decidim/searches/_filters.html.erb

ferblape · 2023-02-27T13:30:13Z

@entantoencuanto could you review the specs also?

carolromero · 2023-02-27T14:40:10Z

There are some missing icons in the filter bar, should we tackle it in this PR? These are the missing ones, some of them are also not in the design prototype:

Participants: 
Groups: 
Conferences: 
Budgets:

Crashillo · 2023-02-27T14:56:15Z

should we tackle it in this PR?

Sure, we're defining the resource icons in the following file, so it's about updating/appending the missing ones

decidim/decidim-core/app/helpers/decidim/icon_helper.rb

Lines 8 to 45 in 1cece9a

    
           DEFAULT_RESOURCE_TYPE_ICONS = { 
        
             "all" => "apps-2-line", 
        
             "Decidim::Proposals::CollaborativeDraft" => "draft-line", 
        
             "Decidim::Comments::Comment" => "chat-1-line", 
        
             "Decidim::Debates::Debate" => "discuss-line", 
        
             "Decidim::Initiative" => "lightbulb-flash-line", 
        
             "Decidim::Meetings::Meeting" => "map-pin-line", 
        
             "Decidim::Blogs::Post" => "pen-nib-line", 
        
             "Decidim::Proposals::Proposal" => "chat-new-line", 
        
             "Decidim::Consultations::Question" => "question-mark", 
        
             "Decidim::Budgets::Order" => "check-double-line", 
        
             "Decidim::Assembly" => "government-line", 
        
             "Decidim::ParticipatoryProcess" => "treasure-map-line", 
        
             "Decidim::Category" => "price-tag-3-line", 
        
             "Decidim::Scope" => "scan-line", 
        
             "Decidim::Conference" => "question-mark", # REDESIGN_PENDING: icon unknown 
        
             "Decidim::Consultation" => "question-mark", # REDESIGN_PENDING: icon unknown 
        
             "Decidim::Votings::Voting" => "check-double-fill", 
        
             "Decidim::Accountability::Result" => "treasure-map-line", 
        
             "comments_count" => "wechat-line", 
        
             "upcoming" => "calendar-2-line", 
        
             "past" => "calendar-check-line", 
        
             "in_person" => "community-line", 
        
             "online" => "webcam-line", 
        
             "hybrid" => "home-wifi-line", 
        
             "official" => "star-line", 
        
             "participants" => "open-arm-line", 
        
             "user_group" => "team-line", 
        
             "user_groups" => "team-line", 
        
             "images" => "image-line", 
        
             "documents" => "file-text-line", 
        
             "like" => "heart-add-line", 
        
             "dislike" => "dislike-line", 
        
             "follow" => "notification-3-line", 
        
             "unfollow" => "notification-3-fill", 
        
             "share" => "share-line", 
        
             "other" => "question-line" 
        
           }.freeze

NilHomedes · 2023-02-28T10:46:51Z

Everything looks good to me. Just two things I've detected:

View all button

I just notice that you are implementing this "View all" button at the end of the resource/space list.

Is this definitive? Just to let you know, the solution should be:

When you search and it shows you different components/spaces results, it should appear the "View all" button at the end of each block.
When you select a component/space in the filter bar, at the end of the result list an index pagination should appear.

Maybe I'm reviewing something out of the scope of this issue, but I just want to point it for the record.

Card items

Another thing, for future reviews of the search result page:
We would review how the Card-L items of each component/space looks like, and what we display in each case.

Tell me if these things are being tackle in this PR or not. If not we can approve this PR and discus it further or on another issue

Crashillo · 2023-02-28T13:30:39Z

View all button

I noticing such feature is still missing. I'll move the PR back and let you know once ready again

Tell me if these things are being tackle in this PR or not.

Nope, the respective L-cards are out of the scope, since it would cause tons of modified files. That will be faced in separate PRs. In the description I've pointed what elements should be tested for this PR

Crashillo · 2023-03-01T15:51:06Z

@NilHomedes pagination is back (> 10 items) when the results are filtered by resource

NilHomedes

LGTM!

entantoencuanto · 2023-03-08T21:34:58Z

Test fixed. The remaining failing tests will be fixed in other branches

alecslupu

…versions * feature/redesign: Redesign: search results (#10380) Redesign: layout item (#10376) Feature/redesign order filter (#10563)

…le-card * feature/redesign: Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Redesign: layout item (#10376) Feature/redesign order filter (#10563)

…ent-blocks * feature/redesign: (97 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) Fix destroying scope types that have been associated with processes (#10496) ...

* feature/redesign: (99 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Feature/redesign order filter (#10563) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) ...

* feature/redesign: (98 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) ...

* feature/redesign: (97 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) Fix destroying scope types that have been associated with processes (#10496) ...

…-l-g * feature/redesign: (99 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Feature/redesign order filter (#10563) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) ...

…content-blocks * feature/redesign: (99 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Feature/redesign order filter (#10563) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) ...

…s-l-g * feature/redesign: (97 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) Fix destroying scope types that have been associated with processes (#10496) ...

* feature/redesign: (97 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) Fix destroying scope types that have been associated with processes (#10496) ...

…dcrumb * feature/redesign: (282 commits) include a clause to change a data-attr on the fly Update tests Restore specs Feature/redesign accountability versions (#10517) set different modals foreach comment Redesign: add image to blog item (#10458) unify report button for futher uses Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Feature/redesign order filter (#10563) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) ...

Crashillo added 2 commits February 13, 2023 17:58

search results section

5658733

first approach to filters section

94da119

alecslupu added the project: redesign Barcelona City Council contract label Feb 14, 2023

Crashillo added 4 commits February 21, 2023 17:15

filters section: restore simplest behaviour

1b68a1b

sort the items by groups

6cf6df9

include all in list

c33325b

fix i18n

4d4e720

Crashillo marked this pull request as ready for review February 23, 2023 12:50

Crashillo requested review from ferblape and furilo February 23, 2023 13:01

change literal

f171605

furilo approved these changes Feb 23, 2023

View reviewed changes

furilo requested a review from a team February 27, 2023 12:45

ferblape assigned entantoencuanto Feb 27, 2023

ferblape reviewed Feb 27, 2023

View reviewed changes

decidim-core/app/views/decidim/searches/_filters.html.erb Outdated Show resolved Hide resolved

include missing icons

3db6df0

Crashillo added 2 commits March 1, 2023 16:13

restore pagination on single results

8013808

Merge branch 'feature/redesign' into feature/redesign-search

25a02b4

Crashillo unassigned entantoencuanto Mar 1, 2023

NilHomedes approved these changes Mar 2, 2023

View reviewed changes

ferblape assigned entantoencuanto Mar 3, 2023

entantoencuanto and others added 2 commits March 3, 2023 11:06

Update top bar search input

782640f

fix top-bar search styles

73ed51f

entantoencuanto added 3 commits March 3, 2023 13:33

Move logic from view to controller

c0a4b55

Update selectors in shared searches examples

dd6a58f

Remove unused translation

f705013

entantoencuanto force-pushed the feature/redesign-search branch from 08810f2 to f705013 Compare March 3, 2023 15:49

Crashillo requested review from entantoencuanto and removed request for entantoencuanto March 7, 2023 10:51

entantoencuanto added 2 commits March 8, 2023 21:54

Fix selectors in tests

8ea850b

Fix HTML validation of redesigned_main_search input

fc4cb9f

entantoencuanto force-pushed the feature/redesign-search branch from 5610cae to fc4cb9f Compare March 8, 2023 20:54

entantoencuanto requested a review from ferblape March 8, 2023 21:35

ferblape approved these changes Mar 9, 2023

View reviewed changes

ferblape unassigned entantoencuanto Mar 9, 2023

ferblape requested a review from a team March 9, 2023 04:15

alecslupu approved these changes Mar 16, 2023

View reviewed changes

ferblape merged commit 8b986a9 into feature/redesign Mar 17, 2023

ferblape deleted the feature/redesign-search branch March 17, 2023 05:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Redesign: search results#10380

Redesign: search results#10380
ferblape merged 17 commits intofeature/redesignfrom
feature/redesign-search

Crashillo commented Feb 13, 2023 •

edited by furilo

Loading

Uh oh!

furilo commented Feb 23, 2023

Uh oh!

Uh oh!

ferblape commented Feb 27, 2023

Uh oh!

carolromero commented Feb 27, 2023

Uh oh!

Crashillo commented Feb 27, 2023

Uh oh!

NilHomedes commented Feb 28, 2023

Uh oh!

Crashillo commented Feb 28, 2023

Uh oh!

Crashillo commented Mar 1, 2023

Uh oh!

NilHomedes left a comment

Uh oh!

entantoencuanto commented Mar 8, 2023

Uh oh!

alecslupu left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

Crashillo commented Feb 13, 2023 • edited by furilo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

Caveats

Pending

📷 Screenshots

Uh oh!

furilo commented Feb 23, 2023

Uh oh!

Uh oh!

ferblape commented Feb 27, 2023

Uh oh!

carolromero commented Feb 27, 2023

Uh oh!

Crashillo commented Feb 27, 2023

Uh oh!

NilHomedes commented Feb 28, 2023

View all button

Card items

Uh oh!

Crashillo commented Feb 28, 2023

Uh oh!

Crashillo commented Mar 1, 2023

Uh oh!

NilHomedes left a comment

Choose a reason for hiding this comment

Uh oh!

entantoencuanto commented Mar 8, 2023

Uh oh!

alecslupu left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Crashillo commented Feb 13, 2023 •

edited by furilo

Loading