Feature/redesign accountability versions#10517
Merged
ferblape merged 6 commits intofeature/redesignfrom Mar 17, 2023
Merged
Conversation
ferblape
approved these changes
Mar 14, 2023
furilo
approved these changes
Mar 16, 2023
NilHomedes
approved these changes
Mar 16, 2023
Member
NilHomedes
left a comment
There was a problem hiding this comment.
Hi, thanks for the work, looks awesome!
Contributor
|
It seems there is an issue with the machine translated versions ... Also, i could get the back button on my local: |
Contributor
Author
Yes, we only change the views of the versions and diffs, but the content remains unchanged, so I think that issue comes from before the redesign
The back link is implemented in the layout item PR so probably if you see locally the version in the branch of this PR you won't see it, but in staging the view has all the elements. In any case, I think that after merging feature/redesign and resolving the conflicts in this branch, the link has been included
|
Contributor
|
Thanks for the merge :
|
alecslupu
approved these changes
Mar 17, 2023
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
…ent-blocks * feature/redesign: (97 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) Fix destroying scope types that have been associated with processes (#10496) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
* feature/redesign: (99 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Feature/redesign order filter (#10563) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
* feature/redesign: (98 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
* feature/redesign: (97 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) Fix destroying scope types that have been associated with processes (#10496) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
…-l-g * feature/redesign: (99 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Feature/redesign order filter (#10563) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
…content-blocks * feature/redesign: (99 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Feature/redesign order filter (#10563) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
…s-l-g * feature/redesign: (97 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) Fix destroying scope types that have been associated with processes (#10496) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
* feature/redesign: (97 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) Fix destroying scope types that have been associated with processes (#10496) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 24, 2023
…dcrumb * feature/redesign: (282 commits) include a clause to change a data-attr on the fly Update tests Restore specs Feature/redesign accountability versions (#10517) set different modals foreach comment Redesign: add image to blog item (#10458) unify report button for futher uses Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Feature/redesign order filter (#10563) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR:
Example URLs where to check it:
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📷 Screenshots
Please add screenshots of the changes you're proposing
