Merged
Conversation
entantoencuanto
approved these changes
Feb 27, 2023
furilo
approved these changes
Mar 9, 2023
Contributor
|
@decidim/product you can review this. We have been playing with different grid configurations and what you can see is our best proposal ;) https://decidim-redesign.populate.tools/processes/smile-cutting/f/12/meetings/11 https://decidim-redesign.populate.tools/processes/book-bless/f/9/posts/5 https://decidim-redesign.populate.tools/processes/book-bless/f/6/results/7 My proposal is to go with this for the moment if there are no significant objections, and adjust along the way once we load Meta Decidim staging data to check against real content. |
ferblape
reviewed
Mar 10, 2023
decidim-debates/app/views/decidim/debates/versions/show.html.erb
Outdated
Show resolved
Hide resolved
ferblape
suggested changes
Mar 10, 2023
decidim-initiatives/app/views/decidim/initiatives/versions/show.html.erb
Outdated
Show resolved
Hide resolved
decidim-proposals/app/views/decidim/proposals/versions/show.html.erb
Outdated
Show resolved
Hide resolved
b578c01 to
176f868
Compare
ferblape
approved these changes
Mar 14, 2023
Contributor
|
@decidim/maintainers this PR is blocking us, could you take a look before other PRs? |
entantoencuanto
added a commit
that referenced
this pull request
Mar 16, 2023
* feature/redesign: Redesign: layout item (#10376)
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
* feature/redesign: (99 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Feature/redesign order filter (#10563) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
* feature/redesign: (98 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
…-l-g * feature/redesign: (99 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Feature/redesign order filter (#10563) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
…content-blocks * feature/redesign: (99 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Feature/redesign order filter (#10563) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 24, 2023
…dcrumb * feature/redesign: (282 commits) include a clause to change a data-attr on the fly Update tests Restore specs Feature/redesign accountability versions (#10517) set different modals foreach comment Redesign: add image to blog item (#10458) unify report button for futher uses Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Feature/redesign order filter (#10563) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Once drawers have been removed, it creates a new layout for such items. Includes some minor pending fixes relatives to responsiveness and deprecated tags.
Closes #10193
Pending
Fill out properly the prev-next links for each layout use, that is:
decidim-meetings/app/views/decidim/meetings/versions/show.html.erb(versions don't have prev-next links)Since the mobile design is still pending, this PR affects only to the desktop version
📌 Related Issues
📷 Screenshots