Redesign: proposals cards#10547
Merged
ferblape merged 2 commits intofeature/redesignfrom Mar 27, 2023
Merged
Conversation
furilo
approved these changes
Mar 17, 2023
ferblape
approved these changes
Mar 17, 2023
Contributor
|
I'll ask @decidim/maintainers to review as well. |
…-l-g * feature/redesign: (99 commits) Feature/redesign accountability versions (#10517) Redesign: add image to blog item (#10458) Redesign: search results (#10380) Fix test Redesign: layout item (#10376) Feature/redesign order filter (#10563) Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) ...
carolromero
reviewed
Mar 23, 2023
Member
carolromero
left a comment
There was a problem hiding this comment.
Hi! As we commented yesterday at the meeting, we understand that this is a WIP and that it is best to review the cards in their context. Just pointing out that our expectation is that all cards G look like this:
Instead of this:
But this is because the format has not yet been applied everywhere, right?
Contributor
Author
That's right. For such reason we opened so many Cards L&G issues, to deal with them separately. In this PR you should focus on the proposal block. The URL above-shared is useful for us to check them all in once, in case anything would get broken or so. |
Contributor
|
ping @decidim/maintainers, could you please review this? |
entantoencuanto
added a commit
that referenced
this pull request
Mar 29, 2023
…content-blocks * feature/redesign: (187 commits) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547) include a clause to change a data-attr on the fly Update tests Restore specs set different modals foreach comment unify report button for futher uses use report_button instead of flag_modal Unify comments:loaded event Remove pending Skip unless redesign enabled Remove turbo reference Remove unused method Remove unused components Disabled examples when redesign is disabled Fix edit comment after comment edited use label component clean duplicated class ...
entantoencuanto
added a commit
that referenced
this pull request
Apr 10, 2023
* feature/redesign: Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547)
entantoencuanto
added a commit
that referenced
this pull request
Apr 13, 2023
* feature/redesign: replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547)
entantoencuanto
added a commit
that referenced
this pull request
Apr 28, 2023
…ent-blocks * feature/redesign: (196 commits) Redesign: process & process group cards (#10716) Redesign: conference cards (#10502) Redesign: pending blogs (#10686) Redesign: blog cards (#10685) Redesign: filters (#10390) replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547) include a clause to change a data-attr on the fly Update tests Restore specs set different modals foreach comment unify report button for futher uses use report_button instead of flag_modal Unify comments:loaded event ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
📌 Related Issues
📷 Screenshots