Redesign: Add a new <aside> to layout item#10620
Merged
ferblape merged 6 commits intofeature/redesignfrom Apr 4, 2023
Merged
Conversation
entantoencuanto
approved these changes
Mar 24, 2023
ferblape
reviewed
Mar 27, 2023
decidim-accountability/app/views/decidim/accountability/results/_project.html.erb
Show resolved
Hide resolved
Contributor
Author
|
@decidim/product ready to review |
ferblape
approved these changes
Mar 31, 2023
alecslupu
suggested changes
Apr 3, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
LGTM. A very small consistency issue, and can be merged.
decidim-core/app/views/layouts/decidim/shared/_layout_item.html.erb
Outdated
Show resolved
Hide resolved
…l.erb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
entantoencuanto
added a commit
that referenced
this pull request
Apr 10, 2023
* feature/redesign: Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547)
entantoencuanto
added a commit
that referenced
this pull request
Apr 13, 2023
* feature/redesign: replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547)
entantoencuanto
added a commit
that referenced
this pull request
Apr 28, 2023
…ent-blocks * feature/redesign: (196 commits) Redesign: process & process group cards (#10716) Redesign: conference cards (#10502) Redesign: pending blogs (#10686) Redesign: blog cards (#10685) Redesign: filters (#10390) replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) Redesign: Add a new <aside> to layout item (#10620) Redesign: author tooltip (#10438) Redesign: pending things of the public profile (#10472) Redesign: card L link whole card (#10554) strip links from cards, standarize author cell (#10547) include a clause to change a data-attr on the fly Update tests Restore specs set different modals foreach comment unify report button for futher uses use report_button instead of flag_modal Unify comments:loaded event ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Add the comment block as a new aside in layout-item. This way, the comment block in the detail of an item is always displayed at the bottom. It fixes a common problem for all items that use the layout-item.
📷 Screenshots
Please add screenshots of the changes you are proposing