Redesign: omnipresent banner#10847
Merged
ferblape merged 5 commits intofeature/redesignfrom May 23, 2023
Merged
Conversation
ferblape
approved these changes
May 12, 2023
Contributor
|
Contributor
|
@decidim/product take a look in case you have more/other comments. |
Contributor
|
(Btw, @decidim/product: I'm not 100% comfortable with using that color - but can't come up with any solid alternative, thus I would proceed with this and think on alternatives during our upcoming design-details-cycle) |
Member
|
@furilo I'm not comfortable with this solution either. At the moment I'd make the following changes and we can see what other ideas come out in the last sprint.:
To give you all the context, we're going to make this banner dismissible in the next iteration. |
Contributor
|
OK, @Crashillo will adjust spacing. What about using a variation of the primary color? Something like 20% for the background. |
Contributor
Author
|
I left the footer color background and the black on hover (as the second footer) |
carolromero
approved these changes
May 16, 2023
Member
carolromero
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @Crashillo!
entantoencuanto
added a commit
that referenced
this pull request
May 26, 2023
entantoencuanto
added a commit
that referenced
this pull request
May 26, 2023
…rafts * feature/redesign: Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699) simplify 2col layout (#10819) Redesign: processes groups content blocks (#10491) Redesign: assemblies content blocks (#10573)
entantoencuanto
added a commit
that referenced
this pull request
May 26, 2023
* feature/redesign: (21 commits) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699) simplify 2col layout (#10819) Redesign: processes groups content blocks (#10491) Redesign: assemblies content blocks (#10573) Redesign: process & process group cards (#10716) Redesign: conference cards (#10502) Redesign: pending blogs (#10686) Redesign: blog cards (#10685) Redesign: filters (#10390) replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) ...
entantoencuanto
added a commit
that referenced
this pull request
Jun 2, 2023
…blies-details-page * feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610)
entantoencuanto
added a commit
that referenced
this pull request
Jun 2, 2023
* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610)
entantoencuanto
added a commit
that referenced
this pull request
Jun 2, 2023
* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699)
entantoencuanto
added a commit
that referenced
this pull request
Jun 2, 2023
* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Redesign version of the omnipresent banner
📌 Related Issues
📷 Screenshots
https://decidim-redesign.populate.tools/