Feature/redesign components breadcrumb by entantoencuanto · Pull Request #10441 · decidim/decidim

entantoencuanto · 2023-02-27T19:58:56Z

🎩 What? Why?

This PR:

Refactors the breadcrumb participatory space generation to be defined from the participatory space context and then be shown in components contained in it
Adds a component breadcrumb item
Refactors and unifies the nav_items generation provided to extended_navigation_bar on legacy design and defines on each participatory space helper the method. This method is used by the breadcrumb participatory space dropdown to generate the nav_items section
Refactors the cell to generate participatory space dropdowns to reuse the maximum of code between the different spaces
Defines dropdown metadata cells to be used in breadcrumb for assemblies, conferences, votings, initiatives and participatory processes
Adds tests for all new cells (Redesign: new breadcrumb pending tests #10247)
Fixes the query of the last activities section of the space breadcrumb dropdown to restrict the results to activities on the space (previously the section was showing all activities)
Adds a HasSpecificBreadcrumb concern to define breadcrumb items on some controllers not related with components inside participatory processes, like profile, users conversations or searches
Add aria-current="page" to the active item
Dropdown menus are triggered on hover

📌 Related Issues

Link your PR to an issue

Testing

Examples of breadcrumbs:

Assemblies, including a component: https://decidim-redesign.populate.tools/assemblies/eix-comunitat/f/149/
Conferences, including a component: https://decidim-redesign.populate.tools/conferences/DecidimFest22/f/1702/
Participatory spaces, including a component: https://decidim-redesign.populate.tools/processes/Decidim4Dummies/f/168/
Votings is pending of integration
Initiatives: Pending of deploy, working locally, reviewing
Breadcrumb item of searches (outside components): https://decidim-redesign.populate.tools/search?term=wadus

📷 Screenshots

Please add screenshots of the changes you're proposing

♥️ Thank you!

…t term

…concern and define breadcrumb cell from space manifest

This reverts commit 51988c1.

…o slug is present

…pace

…ted code

…dcrumb * feature/redesign: Redesign: processes groups content blocks (#10491)

…dcrumb * feature/redesign: Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699) simplify 2col layout (#10819)

alecslupu · 2023-05-22T20:48:04Z

I think the menu needs to be Reviewed, as it seems that has wrong identation:

alecslupu · 2023-05-22T20:50:15Z

The Process seems to be also a little bit of padding :

alecslupu

Checking the local version of the breadcrumb implementation i see some issues with the menu indentation. Based on the staging link, the behavior is not present.

I have a very small change request.

I have seen there are some pipelines that were failing. I have retriggered them, yet, in some cases, the issue persists. Could you have a look ?

...dim-core/app/views/layouts/decidim/header/_redesigned_menu_breadcrumb_mobile_tablet.html.erb

…_breadcrumb_mobile_tablet.html.erb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

Crashillo · 2023-05-23T10:32:08Z

Solved the indentation problem

…dcrumb

ferblape · 2023-05-26T10:00:29Z

Tests and indentation fixed. Merging...

…rafts * feature/redesign: Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699) simplify 2col layout (#10819) Redesign: processes groups content blocks (#10491) Redesign: assemblies content blocks (#10573)

* feature/redesign: Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653)

* feature/redesign: (21 commits) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699) simplify 2col layout (#10819) Redesign: processes groups content blocks (#10491) Redesign: assemblies content blocks (#10573) Redesign: process & process group cards (#10716) Redesign: conference cards (#10502) Redesign: pending blogs (#10686) Redesign: blog cards (#10685) Redesign: filters (#10390) replace uses of specific margin-bottom for layout margins (#10675) Redesign: menu mobile (#10351) Fix comments scss to avoid compilation errors (#10657) ...

* feature/redesign: Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847)

* feature/redesign: Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441)

…blies-details-page * feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610)

* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610)

* feature/redesign: Redesign: amendments (#10765) Redesign: proposals (#10555) Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653) Redesign: Remove reference to commentable in activity cell (#10816) Redesign: spinner (#10848) Redesign: omnipresent banner (#10847) Add redesign enable ENV variable to control the pipeline (#10610) Redesign: progress bar (#10638) Redesign: meeting cards (#10722) Redesign: pending login (#10699)

alecslupu added the project: redesign Barcelona City Council contract label Feb 28, 2023

entantoencuanto mentioned this pull request Mar 6, 2023

Redesign: Pending breadcrumb #10251

Closed

entantoencuanto changed the base branch from develop to feature/redesign March 6, 2023 20:17

entantoencuanto force-pushed the feature/redesign-components-breadcrumb branch from 7f655a6 to 6538c2a Compare March 7, 2023 19:31

entantoencuanto force-pushed the feature/redesign-components-breadcrumb branch 2 times, most recently from 1fd8bc1 to 8ce0c44 Compare April 18, 2023 12:24

entantoencuanto added 11 commits April 18, 2023 15:12

Rename participatory_space_breadcrumb_items using more generic contex…

81789f1

…t term

Move space breadcrumb item defininition to ParticipatorySpaceContext …

8ab8eca

…concern and define breadcrumb cell from space manifest

Define components breadcrumb items from base controller

78d41c5

Define specific meeting breadcrumb item from meetings controller

b4036c2

Move definition of meeting breadcrumb item to a concern

870ac93

Remove breadcrumb item of meeting

f7e43f9

Add breadcrumb items on controllers out of spaces or main menu elements

37def11

Add temporary method to detect paths without breadcrumb

f102007

Add missing breadcrumb items for controllers requiring them

b48d8de

Revert "Add temporary method to detect paths without breadcrumb"

9d5a9ea

This reverts commit 51988c1.

Remove unused BreadCrumbItem concern for meetings

a45eee2

entantoencuanto force-pushed the feature/redesign-components-breadcrumb branch from 8ce0c44 to a45eee2 Compare April 18, 2023 13:12

entantoencuanto added 9 commits April 18, 2023 16:01

Avoid exceptions trying to get the current participatory space when n…

a032153

…o slug is present

Fix last activities query in breadcrumb dropdown of a participatory s…

7d104d5

…pace

Add tests for breadcrumb dropdown metadata in some spaces

e70800b

Adapt components spec to redesigned breadcrumb

748b09f

Define the initiative dropdown metadata cell

0f2b89b

Refactor participatory space dropdown metadata cells to avoid duplica…

8f308f7

…ted code

Move hashtags test to separated shared examples

9a1e0d3

Move voting nav items from cell to a helper

962fb9a

Define the voting dropdown metadata cell

77c5bc2

entantoencuanto requested a review from ferblape April 19, 2023 20:56

entantoencuanto marked this pull request as ready for review April 19, 2023 20:57

Unify conference_nav_items method with equivalent ones

926125b

entantoencuanto and others added 5 commits May 4, 2023 15:48

Merge branch 'feature/redesign' into feature/redesign-components-brea…

4f2a449

…dcrumb * feature/redesign: Redesign: processes groups content blocks (#10491)

replace versions by version

66801a0

Add versions count to path

0671746

Remove buttons in header of participatory process

2a595fe

alecslupu suggested changes May 22, 2023

View reviewed changes

...dim-core/app/views/layouts/decidim/header/_redesigned_menu_breadcrumb_mobile_tablet.html.erb Outdated Show resolved Hide resolved

...dim-core/app/views/layouts/decidim/header/_redesigned_menu_breadcrumb_mobile_tablet.html.erb Outdated Show resolved Hide resolved

ferblape and others added 2 commits May 23, 2023 04:34

Update decidim-core/app/views/layouts/decidim/header/_redesigned_menu…

15232aa

…_breadcrumb_mobile_tablet.html.erb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

Update decidim-core/app/views/layouts/decidim/header/_redesigned_menu…

d275d31

…_breadcrumb_mobile_tablet.html.erb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

andreslucena mentioned this pull request May 23, 2023

Add more disallowed prefixes in the 'Check PR title' workflow #10893

Merged

fix dropdown links

ebdd6b9

Crashillo and others added 5 commits May 23, 2023 12:52

fadein/off dropdown menus

70d675f

TESTING: breadcrumbs with carets

0cd86a1

Merge branch 'feature/redesign' into feature/redesign-components-brea…

d08434c

…dcrumb

fix a11y tests

ac6cd83

Replace click by hover in main menu dropdown tests

9cdf465

ferblape merged commit 5346286 into feature/redesign May 26, 2023

ferblape deleted the feature/redesign-components-breadcrumb branch May 26, 2023 10:00

entantoencuanto added a commit that referenced this pull request May 26, 2023

Merge branch 'feature/redesign' into feature/redesign-staging

b2f0209

* feature/redesign: Feature/redesign components breadcrumb (#10441) Redesign: debates (#10653)

entantoencuanto added a commit that referenced this pull request May 29, 2023

Merge branch 'feature/redesign' into feature/redesign-proposals

109a542

* feature/redesign: Remove unused preset-env dependencies (#10916) Feature/redesign components breadcrumb (#10441)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/redesign components breadcrumb#10441

Feature/redesign components breadcrumb#10441
ferblape merged 51 commits intofeature/redesignfrom
feature/redesign-components-breadcrumb

entantoencuanto commented Feb 27, 2023 •

edited by Crashillo

Loading

Uh oh!

alecslupu commented May 22, 2023

Uh oh!

alecslupu commented May 22, 2023

Uh oh!

alecslupu left a comment

Uh oh!

Uh oh!

Uh oh!

Crashillo commented May 23, 2023

Uh oh!

ferblape commented May 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

entantoencuanto commented Feb 27, 2023 • edited by Crashillo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

Testing

📷 Screenshots

Uh oh!

alecslupu commented May 22, 2023

Uh oh!

alecslupu commented May 22, 2023

Uh oh!

alecslupu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Crashillo commented May 23, 2023

Uh oh!

ferblape commented May 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

entantoencuanto commented Feb 27, 2023 •

edited by Crashillo

Loading