Skip to content

Update npm dependencies#8670

Merged
andreslucena merged 9 commits intodecidim:developfrom
i-need-another-coffee:fix/javascript
Jan 25, 2022
Merged

Update npm dependencies#8670
andreslucena merged 9 commits intodecidim:developfrom
i-need-another-coffee:fix/javascript

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Dec 31, 2021

🎩 What? Why?

Creating the test application, the NPM installer in the decidim:upgrade or decidim:webpacker:install tasks is revealing that there are a number of npm packages that have security issues:

15 vulnerabilities (11 moderate, 4 high)

image

This PR aims to reduce the number libraries vulnerable.

5 vulnerabilities (1 moderate, 4 high)

image

Additionally the following PRs will reduce further the number of reported vulnerabilities :

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@alecslupu alecslupu force-pushed the fix/javascript branch 2 times, most recently from 2da94e9 to 5cb7531 Compare January 1, 2022 23:48
@alecslupu alecslupu changed the title Fix/javascript Upgrade webpacker dependencies Jan 2, 2022
@alecslupu alecslupu marked this pull request as ready for review January 2, 2022 09:42
@andreslucena
Copy link
Copy Markdown
Member

Can you merge with the last changes from develop? There are some commits that are already merged with #8631

@alecslupu
Copy link
Copy Markdown
Contributor Author

Can you merge with the last changes from develop? There are some commits that are already merged with #8631

@andreslucena fixed.

@andreslucena andreslucena added type: internal PRs that aren't necessary to add to the CHANGELOG for implementers and removed target: developer-experience labels Jan 25, 2022
@andreslucena andreslucena changed the title Upgrade webpacker dependencies Upgrade npm dependencies Jan 25, 2022
@andreslucena andreslucena changed the title Upgrade npm dependencies Update npm dependencies Jan 25, 2022
@andreslucena andreslucena merged commit feec80e into decidim:develop Jan 25, 2022
@alecslupu alecslupu deleted the fix/javascript branch January 25, 2022 16:45
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team: security type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants