Skip to content

Remove "leaflet-svgicon" npm dependency #8673

Merged
andreslucena merged 4 commits intodecidim:developfrom
i-need-another-coffee:fix/leaflet-svg-icon
Jan 28, 2022
Merged

Remove "leaflet-svgicon" npm dependency #8673
andreslucena merged 4 commits intodecidim:developfrom
i-need-another-coffee:fix/leaflet-svg-icon

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Jan 2, 2022

🎩 What? Why?

The leaflet-svgicon package has a strange dependency from the src package that seems not to be used. Considering we are using the dependency only to use one file, based on a discussion with @andreslucena , we have concluded that the best option to tackle this, is to add the file in decidim repo, to avoid futher Npm dependency issues over an unmaintained library.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

This was referenced Jan 2, 2022
@alecslupu alecslupu force-pushed the fix/leaflet-svg-icon branch from 64e5b7e to 594e618 Compare January 2, 2022 09:16
@alecslupu alecslupu marked this pull request as draft January 2, 2022 11:12
@alecslupu alecslupu force-pushed the fix/leaflet-svg-icon branch from 594e618 to 2e935f9 Compare January 3, 2022 13:28
@alecslupu alecslupu force-pushed the fix/leaflet-svg-icon branch from 2e935f9 to c8152b0 Compare January 26, 2022 06:40
@alecslupu alecslupu changed the title Use @decidim/leaflet-svg-icon Remove "leaflet-svgicon" npm dependency Jan 26, 2022
@alecslupu alecslupu force-pushed the fix/leaflet-svg-icon branch 3 times, most recently from 68a3603 to 123b863 Compare January 26, 2022 13:29
@alecslupu alecslupu force-pushed the fix/leaflet-svg-icon branch from 123b863 to 6ea3779 Compare January 26, 2022 13:43
@alecslupu alecslupu marked this pull request as ready for review January 26, 2022 15:03
@alecslupu alecslupu self-assigned this Jan 26, 2022
@alecslupu alecslupu added module: core type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Jan 26, 2022
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change in formatting the copyright notice

@andreslucena andreslucena added the dependencies Pull requests that update a dependency file or issues that talk about updating dependencies label Jan 28, 2022
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@alecslupu alecslupu force-pushed the fix/leaflet-svg-icon branch from ab664c9 to 7cade90 Compare January 28, 2022 10:51
@andreslucena andreslucena merged commit 3d4ec74 into decidim:develop Jan 28, 2022
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
@alecslupu alecslupu deleted the fix/leaflet-svg-icon branch October 31, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file or issues that talk about updating dependencies module: core type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants