Remove "leaflet-svgicon" npm dependency #8673
Merged
andreslucena merged 4 commits intodecidim:developfrom Jan 28, 2022
Merged
Conversation
This was referenced Jan 2, 2022
64e5b7e to
594e618
Compare
594e618 to
2e935f9
Compare
2e935f9 to
c8152b0
Compare
68a3603 to
123b863
Compare
123b863 to
6ea3779
Compare
andreslucena
requested changes
Jan 28, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Just a small change in formatting the copyright notice
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
ab664c9 to
7cade90
Compare
andreslucena
approved these changes
Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The leaflet-svgicon package has a strange dependency from the src package that seems not to be used. Considering we are using the dependency only to use one file, based on a discussion with @andreslucena , we have concluded that the best option to tackle this, is to add the file in decidim repo, to avoid futher Npm dependency issues over an unmaintained library.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
