Closed
Conversation
Rails installs webpacker when creating the app, so we were installing webpacker twice.
e7ee639 to
10c5c0a
Compare
10c5c0a to
a07fef6
Compare
a07fef6 to
160f52a
Compare
b75cb94 to
ce12acd
Compare
160f52a to
8011950
Compare
Contributor
|
@andreslucena , there are a lot of changes in this branch , and the documentation has a double render of layout. |
12 tasks
Contributor
|
@andreslucena , This Pull request has been split into:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Some NPM packages used by the project are very old. This could affect the project maintenaince and security, as it's not possible to update packages with recent versions. This PR tries to improve that.
These are the main issues found:
graphql-docsnpm package is very old and it's not maintained. I've tried to update it but it requires too much work to do it. I've found a gem also calledgraphql-docsthat generates a very similar output but statically. I've created a rake task that uses it and generates those static files in theapp/views/static/folder. Then, I've embeded those files into the docs view, to get a result very similar to the existing solution. The task can be run manually, but it will be run after the creation of the app and after each decidim upgrade. The only "problem" is that this static files should be added to the app repository, and that's a bit ugly.leaflet-svgiconpackage has a strange dependency from thesrcpackage that seems not to be used. This package was not created by the original code writer. I've created a fork from that repository and published it as a package called@decidim/leaflet-svgicon.📌 Related Issues
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
