Skip to content

Update old JS dependencies#8335

Closed
leio10 wants to merge 22 commits intodevelopfrom
chore/update-js-dependencies
Closed

Update old JS dependencies#8335
leio10 wants to merge 22 commits intodevelopfrom
chore/update-js-dependencies

Conversation

@leio10
Copy link
Copy Markdown
Contributor

@leio10 leio10 commented Sep 16, 2021

🎩 What? Why?

Some NPM packages used by the project are very old. This could affect the project maintenaince and security, as it's not possible to update packages with recent versions. This PR tries to improve that.

These are the main issues found:

  • The graphql-docs npm package is very old and it's not maintained. I've tried to update it but it requires too much work to do it. I've found a gem also called graphql-docs that generates a very similar output but statically. I've created a rake task that uses it and generates those static files in the app/views/static/ folder. Then, I've embeded those files into the docs view, to get a result very similar to the existing solution. The task can be run manually, but it will be run after the creation of the app and after each decidim upgrade. The only "problem" is that this static files should be added to the app repository, and that's a bit ugly.
  • The leaflet-svgicon package has a strange dependency from the src package that seems not to be used. This package was not created by the original code writer. I've created a fork from that repository and published it as a package called @decidim/leaflet-svgicon.

📌 Related Issues

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@leio10 leio10 force-pushed the chore/update-js-dependencies branch from e7ee639 to 10c5c0a Compare September 16, 2021 10:03
@leio10 leio10 force-pushed the chore/update-js-dependencies branch from 10c5c0a to a07fef6 Compare September 16, 2021 14:00
@leio10 leio10 changed the base branch from develop to chore/fix-npm-packages September 16, 2021 14:01
@leio10 leio10 force-pushed the chore/update-js-dependencies branch from a07fef6 to 160f52a Compare September 16, 2021 14:25
@leio10 leio10 force-pushed the chore/fix-npm-packages branch from b75cb94 to ce12acd Compare September 16, 2021 14:38
@leio10 leio10 force-pushed the chore/update-js-dependencies branch from 160f52a to 8011950 Compare September 16, 2021 14:41
Base automatically changed from chore/fix-npm-packages to develop September 16, 2021 17:23
@alecslupu
Copy link
Copy Markdown
Contributor

@andreslucena , there are a lot of changes in this branch , and the documentation has a double render of layout.
I have opened #8631 to fix the documentation.

@alecslupu
Copy link
Copy Markdown
Contributor

@andreslucena , This Pull request has been split into:

@alecslupu alecslupu closed this Jan 2, 2022
@andreslucena andreslucena deleted the chore/update-js-dependencies branch March 4, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants