Skip to content

Fix for exporting deleted and hidden comments#10629

Merged
fblupi merged 1 commit intodevelopfrom
fix/10613
Mar 28, 2023
Merged

Fix for exporting deleted and hidden comments#10629
fblupi merged 1 commit intodevelopfrom
fix/10613

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

In all the decidim versions, you currently can export all the comments attached to a resource. This PR implements adds the .not_hidden and .not_deleted scopes, in order to remove from export the moderated and hidden comments.

📌 Related Issues

Link your PR to an issue

Testing

  1. Go to public interface of a proposal
  2. Add several comments, moderate or delete some of those
  3. Go to admin space for that proposal, export all the comments
  4. See in the attached mail the exported comments containing moderated and hidden resources
  5. Apply patch
  6. Go to admin space for that proposal, export all the comments
  7. See in the attached mail the exported comments NOT containing moderated and hidden resources

♥️ Thank you!

@alecslupu alecslupu added module: comments type: fix PRs that implement a fix for a bug labels Mar 24, 2023
@alecslupu alecslupu requested a review from a team March 25, 2023 00:04
@alecslupu alecslupu marked this pull request as ready for review March 25, 2023 00:04
@andreslucena andreslucena changed the title Fix Deleted and hidden comments are exported Fix for exporting deleted and hidden comments Mar 28, 2023
Copy link
Copy Markdown
Member

@fblupi fblupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fblupi fblupi merged commit 74a86ce into develop Mar 28, 2023
@fblupi fblupi deleted the fix/10613 branch March 28, 2023 11:40
entantoencuanto added a commit that referenced this pull request Jun 8, 2023
* feature/redesign: (70 commits)
  Fix failing specs
  Redesign sortitions (#10831)
  Redesign: data toggle (#10886)
  Redesign: collaborative drafts (#10729)
  Redesign: pending pages (#10944)
  Redesign: my account (#10904)
  use foundation classes instead of default html validation (#10921)
  Fix failings redesign specs
  Add gitpod support (#10641)
  Fix pipeline after #10409 (#10670)
  Upgrade webpack and other javascript libraries (#10643)
  New Crowdin updates (#10409)
  Refactor attachment title (#10103)
  Fix for exporting hidden moderated proposals (#10630)
  Fix Exception as admin on a Proposal with meeting author (#10628)
  Fix: Deleted and hidden comments are exported (#10629)
  Rename "terms and conditions" to "terms of service" (#10614)
  Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606)
  Standardize the format of the words "they will" (#10617)
  Fix the spec after word standardization (#10624)
  ...
entantoencuanto added a commit that referenced this pull request Jun 12, 2023
…blies-details-page

* feature/redesign: (71 commits)
  Unskip tests (#10951)
  Fix failing specs
  Redesign sortitions (#10831)
  Redesign: data toggle (#10886)
  Redesign: collaborative drafts (#10729)
  Redesign: pending pages (#10944)
  Redesign: my account (#10904)
  use foundation classes instead of default html validation (#10921)
  Fix failings redesign specs
  Add gitpod support (#10641)
  Fix pipeline after #10409 (#10670)
  Upgrade webpack and other javascript libraries (#10643)
  New Crowdin updates (#10409)
  Refactor attachment title (#10103)
  Fix for exporting hidden moderated proposals (#10630)
  Fix Exception as admin on a Proposal with meeting author (#10628)
  Fix: Deleted and hidden comments are exported (#10629)
  Rename "terms and conditions" to "terms of service" (#10614)
  Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606)
  Standardize the format of the words "they will" (#10617)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: comments type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleted and hidden comments are exported

2 participants