Skip to content

Fix Exception as admin on a Proposal with meeting author#10628

Merged
fblupi merged 3 commits intodevelopfrom
fix/10623
Mar 28, 2023
Merged

Fix Exception as admin on a Proposal with meeting author#10628
fblupi merged 3 commits intodevelopfrom
fix/10623

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

When an administrator, visits a Proposal of which author is a Meeting, I see an exception (error 500)

📌 Related Issues

Link your PR to an issue

Testing

  1. Sign in as admin
  2. Go to a Proposal whose author is a Meeting
  3. See exception
  4. Apply patch
  5. Go to a Proposal whose author is a Meeting, see there is no error.

♥️ Thank you!

@alecslupu alecslupu added type: fix PRs that implement a fix for a bug release: v0.28 Issues or PRs that need to be tackled for v0.28 labels Mar 24, 2023
@alecslupu alecslupu requested a review from a team March 24, 2023 14:24
@alecslupu alecslupu marked this pull request as ready for review March 24, 2023 14:24
@alecslupu alecslupu changed the title Fix: Exception as admin on a Proposal with meeting author Fix Exception as admin on a Proposal with meeting author Mar 25, 2023
@alecslupu alecslupu requested a review from fblupi March 28, 2023 11:55
Copy link
Copy Markdown
Member

@fblupi fblupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fblupi fblupi merged commit be69a94 into develop Mar 28, 2023
@fblupi fblupi deleted the fix/10623 branch March 28, 2023 14:21
entantoencuanto added a commit that referenced this pull request Jun 8, 2023
* feature/redesign: (70 commits)
  Fix failing specs
  Redesign sortitions (#10831)
  Redesign: data toggle (#10886)
  Redesign: collaborative drafts (#10729)
  Redesign: pending pages (#10944)
  Redesign: my account (#10904)
  use foundation classes instead of default html validation (#10921)
  Fix failings redesign specs
  Add gitpod support (#10641)
  Fix pipeline after #10409 (#10670)
  Upgrade webpack and other javascript libraries (#10643)
  New Crowdin updates (#10409)
  Refactor attachment title (#10103)
  Fix for exporting hidden moderated proposals (#10630)
  Fix Exception as admin on a Proposal with meeting author (#10628)
  Fix: Deleted and hidden comments are exported (#10629)
  Rename "terms and conditions" to "terms of service" (#10614)
  Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606)
  Standardize the format of the words "they will" (#10617)
  Fix the spec after word standardization (#10624)
  ...
entantoencuanto added a commit that referenced this pull request Jun 12, 2023
…blies-details-page

* feature/redesign: (71 commits)
  Unskip tests (#10951)
  Fix failing specs
  Redesign sortitions (#10831)
  Redesign: data toggle (#10886)
  Redesign: collaborative drafts (#10729)
  Redesign: pending pages (#10944)
  Redesign: my account (#10904)
  use foundation classes instead of default html validation (#10921)
  Fix failings redesign specs
  Add gitpod support (#10641)
  Fix pipeline after #10409 (#10670)
  Upgrade webpack and other javascript libraries (#10643)
  New Crowdin updates (#10409)
  Refactor attachment title (#10103)
  Fix for exporting hidden moderated proposals (#10630)
  Fix Exception as admin on a Proposal with meeting author (#10628)
  Fix: Deleted and hidden comments are exported (#10629)
  Rename "terms and conditions" to "terms of service" (#10614)
  Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606)
  Standardize the format of the words "they will" (#10617)
  ...
@alecslupu alecslupu added the no-backport Pull Requests that should not be backported label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-backport Pull Requests that should not be backported release: v0.28 Issues or PRs that need to be tackled for v0.28 type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception as admin on a Proposal with meeting author

2 participants