Redesign: collaborative drafts#10729
Merged
ferblape merged 74 commits intofeature/redesignfrom Jun 7, 2023
Merged
Conversation
3 tasks
0518aec to
936061e
Compare
Contributor
|
@Crashillo could you lint the code? |
2cf6773 to
936061e
Compare
Contributor
Author
|
I've removed the last commit since the compilation fails. |
Contributor
|
@Crashillo since #10765 is already approved, maybe you could merge that one, so we can remove also other skipped tests ? |
Contributor
|
@Crashillo before i get another look at this, could you have a look on the proposal spec that is currently failing ? |
Contributor
This test for some reason fails on GitHub almost every time, but on local it works fine. I'm looking for an alternative |
f8b05d5 to
fa94bc5
Compare
Contributor
|
Hi, @alecslupu , I've skipped 2 tests and open an issue to fix it (#10961). I've tried some things but the tests seems to be be resistant in its rebellion :( |
alecslupu
suggested changes
Jun 7, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
One small change to do, and we are good to go.
decidim-proposals/app/views/decidim/proposals/collaborative_drafts/_edit_form_fields.html.erb
Outdated
Show resolved
Hide resolved
…afts/_edit_form_fields.html.erb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
approved these changes
Jun 7, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
Thanks for changes. LGTM.
entantoencuanto
added a commit
that referenced
this pull request
Jun 8, 2023
* feature/redesign: (70 commits) Fix failing specs Redesign sortitions (#10831) Redesign: data toggle (#10886) Redesign: collaborative drafts (#10729) Redesign: pending pages (#10944) Redesign: my account (#10904) use foundation classes instead of default html validation (#10921) Fix failings redesign specs Add gitpod support (#10641) Fix pipeline after #10409 (#10670) Upgrade webpack and other javascript libraries (#10643) New Crowdin updates (#10409) Refactor attachment title (#10103) Fix for exporting hidden moderated proposals (#10630) Fix Exception as admin on a Proposal with meeting author (#10628) Fix: Deleted and hidden comments are exported (#10629) Rename "terms and conditions" to "terms of service" (#10614) Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606) Standardize the format of the words "they will" (#10617) Fix the spec after word standardization (#10624) ...
entantoencuanto
added a commit
that referenced
this pull request
Jun 12, 2023
…blies-details-page * feature/redesign: (71 commits) Unskip tests (#10951) Fix failing specs Redesign sortitions (#10831) Redesign: data toggle (#10886) Redesign: collaborative drafts (#10729) Redesign: pending pages (#10944) Redesign: my account (#10904) use foundation classes instead of default html validation (#10921) Fix failings redesign specs Add gitpod support (#10641) Fix pipeline after #10409 (#10670) Upgrade webpack and other javascript libraries (#10643) New Crowdin updates (#10409) Refactor attachment title (#10103) Fix for exporting hidden moderated proposals (#10630) Fix Exception as admin on a Proposal with meeting author (#10628) Fix: Deleted and hidden comments are exported (#10629) Rename "terms and conditions" to "terms of service" (#10614) Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606) Standardize the format of the words "they will" (#10617) ...
entantoencuanto
added a commit
that referenced
this pull request
Jun 15, 2023
…ations * feature/redesign: (78 commits) Redesign: initiatives (#10646) Redesign: surveys (#10922) Redesign: coauthors (#10954) remove font-bold from breadcrumb (#10990) Redesign: participatory texts (#10941) Redesign: budgets (#10195) Redesign: fix buttons & geocoder (#10975) Unskip tests (#10951) Fix failing specs Redesign sortitions (#10831) Redesign: data toggle (#10886) Redesign: collaborative drafts (#10729) Redesign: pending pages (#10944) Redesign: my account (#10904) use foundation classes instead of default html validation (#10921) Fix failings redesign specs Add gitpod support (#10641) Fix pipeline after #10409 (#10670) Upgrade webpack and other javascript libraries (#10643) New Crowdin updates (#10409) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Includes the redesign of the collaborative drafts (within proposals module)
Caveats
Pending stuff addressed elsewhere:
Pending
📌 Related Issues
Fixes #10634
📷 Screenshots
1 Login as different users to display conditional markup