Skip to content

Redesign: coauthors#10954

Merged
ferblape merged 14 commits intofeature/redesignfrom
feature/redesign-coauthors
Jun 14, 2023
Merged

Redesign: coauthors#10954
ferblape merged 14 commits intofeature/redesignfrom
feature/redesign-coauthors

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented Jun 6, 2023

🎩 What? Why?

Handle multiple authors for proposals, amendsments and collaborative_drafts

📌 Related Issues

📷 Screenshots

♥️ Thank you!

@Crashillo Crashillo linked an issue Jun 6, 2023 that may be closed by this pull request
@Crashillo Crashillo added the project: redesign Barcelona City Council contract label Jun 6, 2023
@Crashillo Crashillo marked this pull request as ready for review June 6, 2023 09:22
@Crashillo Crashillo requested a review from entantoencuanto June 6, 2023 09:24
@Crashillo Crashillo requested review from ferblape and furilo June 6, 2023 15:41
@furilo furilo requested a review from a team June 7, 2023 07:34
Comment thread decidim-proposals/spec/cells/decidim/proposals/collaborative_draft_cell_spec.rb Outdated
Copy link
Copy Markdown
Member

@carolromero carolromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Crashillo!

@ferblape ferblape requested a review from alecslupu June 9, 2023 06:13
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending to perform local testing.

end

it "does not render comments" do
skip "REDESIGN_PENDING - Deprecated remove the entire file once fully enabled redesign and removed the m-card"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refs #10195

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image
image

@ferblape ferblape merged commit 3d66603 into feature/redesign Jun 14, 2023
@ferblape ferblape deleted the feature/redesign-coauthors branch June 14, 2023 04:21
entantoencuanto added a commit that referenced this pull request Jun 14, 2023
* feature/redesign:
  Redesign: surveys (#10922)
  Redesign: coauthors (#10954)
  remove font-bold from breadcrumb (#10990)
  Redesign: participatory texts (#10941)
  Redesign: budgets (#10195)
  Redesign: fix buttons & geocoder (#10975)
  Unskip tests (#10951)
entantoencuanto added a commit that referenced this pull request Jun 14, 2023
* feature/redesign:
  Redesign: surveys (#10922)
  Redesign: coauthors (#10954)
  remove font-bold from breadcrumb (#10990)
  Redesign: participatory texts (#10941)
entantoencuanto added a commit that referenced this pull request Jun 15, 2023
…ations

* feature/redesign: (78 commits)
  Redesign: initiatives (#10646)
  Redesign: surveys (#10922)
  Redesign: coauthors (#10954)
  remove font-bold from breadcrumb (#10990)
  Redesign: participatory texts (#10941)
  Redesign: budgets (#10195)
  Redesign: fix buttons & geocoder (#10975)
  Unskip tests (#10951)
  Fix failing specs
  Redesign sortitions (#10831)
  Redesign: data toggle (#10886)
  Redesign: collaborative drafts (#10729)
  Redesign: pending pages (#10944)
  Redesign: my account (#10904)
  use foundation classes instead of default html validation (#10921)
  Fix failings redesign specs
  Add gitpod support (#10641)
  Fix pipeline after #10409 (#10670)
  Upgrade webpack and other javascript libraries (#10643)
  New Crowdin updates (#10409)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Redesign: co-authors cell

6 participants