Merged
Conversation
This is required because the modal is rendered with a cell and the method is delegated to controller. If those methods are private calling them from cell raises exceptions
ferblape
reviewed
Jun 12, 2023
decidim-initiatives/app/views/decidim/initiatives/initiatives/index.html.erb
Outdated
Show resolved
Hide resolved
ferblape
approved these changes
Jun 12, 2023
alecslupu
suggested changes
Jun 12, 2023
decidim-core/app/cells/decidim/content_blocks/participatory_space_main_data/nav_links.erb
Outdated
Show resolved
Hide resolved
decidim-initiatives/app/controllers/decidim/initiatives/create_initiative_controller.rb
Show resolved
Hide resolved
decidim-initiatives/app/views/decidim/initiatives/create_initiative/fill_data.html.erb
Show resolved
Hide resolved
decidim-initiatives/app/views/decidim/initiatives/initiatives/_index_header.html.erb
Outdated
Show resolved
Hide resolved
decidim-initiatives/app/views/layouts/decidim/initiative.html.erb
Outdated
Show resolved
Hide resolved
decidim-initiatives/app/views/layouts/decidim/redesigned_initiative.html.erb
Outdated
Show resolved
Hide resolved
decidim-initiatives/app/views/layouts/decidim/redesigned_initiative_creation.html.erb
Outdated
Show resolved
Hide resolved
decidim-initiatives/spec/cells/decidim/initiatives/initiative_m_cell_spec.rb
Outdated
Show resolved
Hide resolved
…into feature/redesign-initiatives
…idim/decidim into feature/redesign-initiatives
Contributor
|
I came across an initiative where i can see the edit button, but when i click on it, i receive an error message. Maybe it would be ok not to display the button if the permissions are not sufficient. |
Contributor
|
I have some issues properly observing : |
entantoencuanto
added a commit
that referenced
this pull request
Jun 15, 2023
…ations * feature/redesign: (78 commits) Redesign: initiatives (#10646) Redesign: surveys (#10922) Redesign: coauthors (#10954) remove font-bold from breadcrumb (#10990) Redesign: participatory texts (#10941) Redesign: budgets (#10195) Redesign: fix buttons & geocoder (#10975) Unskip tests (#10951) Fix failing specs Redesign sortitions (#10831) Redesign: data toggle (#10886) Redesign: collaborative drafts (#10729) Redesign: pending pages (#10944) Redesign: my account (#10904) use foundation classes instead of default html validation (#10921) Fix failings redesign specs Add gitpod support (#10641) Fix pipeline after #10409 (#10670) Upgrade webpack and other javascript libraries (#10643) New Crowdin updates (#10409) ...
entantoencuanto
added a commit
that referenced
this pull request
Jun 23, 2023
* feature/redesign: (26 commits) Use the component name in the sidebar title (#11088) Redesign: layout center (#11068) Redesign: display only public users followings in following profile tab (#11051) Redesign: fix cards (#11072) Redesign: remove gcalendar warning (#10999) lock sass-embedded (#11077) Redesign: scopes picker (#11039) Redesign: pending notifications (#10926) Redesign: change the filters style (#11049) Redesign: secondary actions (#11067) Redesign: assembly members page (#10992) Redesign: update default static map size to 300px (#10953) Redesign: visual placeholder cards (#11038) Redesign: fix emoji popup position (#10957) Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983) Redesign: opinion buttons (#10998) Display a disabled message button in public profile if user blocks them instead of hidding it (#10984) Redesign: confirm modal Foundation-free (#10978) Redesign: initiatives (#10646) Redesign: surveys (#10922) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR implements the redesign in initiatives module:
📌 Related Issues
Link your PR to an issue
Closes Redesign initiatives / Item navigation menu #10828
Pending