Skip to content

Redesign: pending notifications#10926

Merged
ferblape merged 10 commits intofeature/redesignfrom
feature/redesign-pending-notifications
Jun 21, 2023
Merged

Redesign: pending notifications#10926
ferblape merged 10 commits intofeature/redesignfrom
feature/redesign-pending-notifications

Conversation

@entantoencuanto
Copy link
Copy Markdown
Contributor

@entantoencuanto entantoencuanto commented May 30, 2023

🎩 What? Why?

This PR fixes some pending issues in notifications:

  • Adds the full content of comments on notifications
  • Includes the tick of pending in the user dropdown menu Notifications and Conversations if there are pending to read elements on each
  • Adds some js to delete the tick of pending after clicking the "Mark all as read" in notifications
  • Adapts notifications tests to redesign

📌 Related Issues

Link your PR to an issue

Testing

Sign in and visit https://decidim-redesign.populate.tools/notifications

📷 Screenshots

Screenshot from 2023-05-30 12-32-36
Screenshot from 2023-05-30 12-33-00

♥️ Thank you!

@entantoencuanto entantoencuanto added the project: redesign Barcelona City Council contract label May 30, 2023
@entantoencuanto entantoencuanto force-pushed the feature/redesign-pending-notifications branch from 2535202 to 52c9d89 Compare May 30, 2023 11:25
@entantoencuanto entantoencuanto marked this pull request as ready for review May 30, 2023 14:10
@furilo
Copy link
Copy Markdown
Contributor

furilo commented May 30, 2023

It seems we are missing styles for the paragraphs; this also happens in comments. @Crashillo should we fix that here or in another PR?

image image

https://decidim-redesign.populate.tools/assemblies/eix-comunitat/f/149/meetings/1809

@andreslucena andreslucena changed the title Redesign: Pending notifications Redesign: pending notifications May 31, 2023
@entantoencuanto
Use the same sanitizer on comment event and comment show allowing to …
9ea7d01 
…use an override_translation argument to instance method
@entantoencuanto entantoencuanto force-pushed the feature/redesign-pending-notifications branch from 1369eaf to 9ea7d01 Compare June 1, 2023 11:38
Crashillo and others added 2 commits June 1, 2023 14:17
@furilo
Copy link
Copy Markdown
Contributor

furilo commented Jun 2, 2023

@decidim/product we keep having a little inconsistency in the styles of different items, but I would close this and work in the styles in the coming weeks, because we'll have to adjust this same things in other places, and we already have some issues in place.

@carolromero
Copy link
Copy Markdown
Member

carolromero commented Jun 7, 2023 •
edited
Loading

@decidim/product we keep having a little inconsistency in the styles of different items, but I would close this and work in the styles in the coming weeks, because we'll have to adjust this same things in other places, and we already have some issues in place.

@furilo I was going to submit my review with the following changes:

  • remove the reference to the resource
  • fix font-style and font-size for the comments content

I can put it in a separate issue if you prefer.

@furilo
Copy link
Copy Markdown
Contributor

furilo commented Jun 7, 2023

OK, @entantoencuanto lets do -> remove the reference to the resource, and the type thing we'll do it in further PRs.

@furilo
Copy link
Copy Markdown
Contributor

furilo commented Jun 15, 2023

@carolromero by resource you mean these lines, right?

image

@carolromero
Copy link
Copy Markdown
Member

carolromero commented Jun 15, 2023

by resource you mean these lines, right?

@furilo that's right!

@entantoencuanto
Merge branch 'feature/redesign' into feature/redesign-pending-notific…
c871874 
…ations

* feature/redesign: (78 commits)
  Redesign: initiatives (#10646)
  Redesign: surveys (#10922)
  Redesign: coauthors (#10954)
  remove font-bold from breadcrumb (#10990)
  Redesign: participatory texts (#10941)
  Redesign: budgets (#10195)
  Redesign: fix buttons & geocoder (#10975)
  Unskip tests (#10951)
  Fix failing specs
  Redesign sortitions (#10831)
  Redesign: data toggle (#10886)
  Redesign: collaborative drafts (#10729)
  Redesign: pending pages (#10944)
  Redesign: my account (#10904)
  use foundation classes instead of default html validation (#10921)
  Fix failings redesign specs
  Add gitpod support (#10641)
  Fix pipeline after #10409 (#10670)
  Upgrade webpack and other javascript libraries (#10643)
  New Crowdin updates (#10409)
  ...
@entantoencuanto
Move current user unread_data to a helper
ad5845f
@entantoencuanto
Remove notification__snippet-resource element from notifications
2dc5d92
@entantoencuanto
Copy link
Copy Markdown
Contributor Author

entantoencuanto commented Jun 16, 2023

Resource reference removed! I'll be watching the pipeline in case any test breaks

@ferblape ferblape requested a review from a team June 17, 2023 04:30
carolromero
carolromero approved these changes Jun 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@carolromero carolromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 thanks @entantoencuanto!

@ferblape ferblape requested a review from a team June 19, 2023 09:41
@ferblape ferblape merged commit 76de4ad into feature/redesign Jun 21, 2023
@ferblape ferblape deleted the feature/redesign-pending-notifications branch June 21, 2023 04:23
entantoencuanto added a commit that referenced this pull request Jun 23, 2023
@entantoencuanto
Merge branch 'feature/redesign' into feature/redesign-pending-assemblies
d668fe1 
* feature/redesign: (26 commits)
  Use the component name in the sidebar title (#11088)
  Redesign: layout center (#11068)
  Redesign: display only public users followings in following profile tab (#11051)
  Redesign: fix cards (#11072)
  Redesign: remove gcalendar warning (#10999)
  lock sass-embedded (#11077)
  Redesign: scopes picker (#11039)
  Redesign: pending notifications (#10926)
  Redesign: change the filters style (#11049)
  Redesign: secondary actions (#11067)
  Redesign: assembly members page (#10992)
  Redesign: update default static map size to 300px (#10953)
  Redesign: visual placeholder cards (#11038)
  Redesign: fix emoji popup position (#10957)
  Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983)
  Redesign: opinion buttons (#10998)
  Display a disabled message button in public profile if user blocks them instead of hidding it (#10984)
  Redesign: confirm modal Foundation-free (#10978)
  Redesign: initiatives (#10646)
  Redesign: surveys (#10922)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carolromero carolromero carolromero approved these changes

+2 more reviewers

@ferblape ferblape ferblape approved these changes

@furilo furilo furilo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
PX Redesign
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@entantoencuanto @furilo @carolromero @ferblape @Crashillo