Skip to content

Redesign: opinion buttons#10998

Merged
ferblape merged 6 commits intofeature/redesignfrom
feature/redesign-comments-form
Jun 18, 2023
Merged

Redesign: opinion buttons#10998
ferblape merged 6 commits intofeature/redesignfrom
feature/redesign-comments-form

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented Jun 13, 2023

🎩 What? Why?

Redesign the evaluation buttons and place the character counter at the topleft

📌 Related Issues

📷 Screenshots

https://decidim-redesign.populate.tools/processes/Decidim4Dummies/f/170/proposals/12184

♥️ Thank you!

@Crashillo Crashillo added the project: redesign Barcelona City Council contract label Jun 13, 2023
@Crashillo Crashillo requested review from ferblape and furilo June 13, 2023 13:37
@Crashillo Crashillo linked an issue Jun 13, 2023 that may be closed by this pull request
@Crashillo Crashillo force-pushed the feature/redesign-comments-form branch from 5ef59e4 to bd0bdd9 Compare June 13, 2023 16:00
@furilo
Copy link
Copy Markdown
Contributor

furilo commented Jun 14, 2023

@decidim/product just to confirm we should use the labels "In favor" / "Against" in the buttons, to match with the label shown in the comment, right?

image

@carolromero
Copy link
Copy Markdown
Member

@furilo correct, they should match.

@Crashillo Crashillo requested a review from a team June 14, 2023 15:43
Copy link
Copy Markdown
Member

@carolromero carolromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, thanks @Crashillo. I just noticed that emojis are not loading though:
image

@furilo
Copy link
Copy Markdown
Contributor

furilo commented Jun 15, 2023 via email

@carolromero
Copy link
Copy Markdown
Member

Loading correctly now.

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@ferblape ferblape merged commit 074ed21 into feature/redesign Jun 18, 2023
@ferblape ferblape deleted the feature/redesign-comments-form branch June 18, 2023 06:15
entantoencuanto added a commit that referenced this pull request Jun 20, 2023
* feature/redesign:
  Redesign: change the filters style (#11049)
  Redesign: secondary actions (#11067)
  Redesign: assembly members page (#10992)
  Redesign: update default static map size to 300px (#10953)
  Redesign: visual placeholder cards (#11038)
  Redesign: fix emoji popup position (#10957)
  Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983)
  Redesign: opinion buttons (#10998)
  Display a disabled message button in public profile if user blocks them instead of hidding it (#10984)
  Redesign: confirm modal Foundation-free (#10978)
entantoencuanto added a commit that referenced this pull request Jun 23, 2023
* feature/redesign: (26 commits)
  Use the component name in the sidebar title (#11088)
  Redesign: layout center (#11068)
  Redesign: display only public users followings in following profile tab (#11051)
  Redesign: fix cards (#11072)
  Redesign: remove gcalendar warning (#10999)
  lock sass-embedded (#11077)
  Redesign: scopes picker (#11039)
  Redesign: pending notifications (#10926)
  Redesign: change the filters style (#11049)
  Redesign: secondary actions (#11067)
  Redesign: assembly members page (#10992)
  Redesign: update default static map size to 300px (#10953)
  Redesign: visual placeholder cards (#11038)
  Redesign: fix emoji popup position (#10957)
  Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983)
  Redesign: opinion buttons (#10998)
  Display a disabled message button in public profile if user blocks them instead of hidding it (#10984)
  Redesign: confirm modal Foundation-free (#10978)
  Redesign: initiatives (#10646)
  Redesign: surveys (#10922)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Redesign / Comments: form

5 participants