Merged
Conversation
874a783 to
f5baec1
Compare
furilo
approved these changes
Jun 16, 2023
carolromero
requested changes
Jun 19, 2023
Member
carolromero
left a comment
There was a problem hiding this comment.
Hi @jorgeatgu! Before moving forward:
- let's leave the font weight at 600, as in other places
Thanks!
carolromero
approved these changes
Jun 19, 2023
Member
carolromero
left a comment
There was a problem hiding this comment.
Ups this was the review for #11049, sorry! This one looks good to me :)
Member
|
@entantoencuanto I've added the screenshot so this change is documented. This change will introduce UI issues in installations like decidim.barcelona, where there are 83 scopes (10 scopes/districs and 73 child scopes/neighborhoods). This can be mitigated by JS libraries like we've been discussing in #8683 (or other, but ideally we could reuse the same component here) |
entantoencuanto
added a commit
that referenced
this pull request
Jun 23, 2023
* feature/redesign: (26 commits) Use the component name in the sidebar title (#11088) Redesign: layout center (#11068) Redesign: display only public users followings in following profile tab (#11051) Redesign: fix cards (#11072) Redesign: remove gcalendar warning (#10999) lock sass-embedded (#11077) Redesign: scopes picker (#11039) Redesign: pending notifications (#10926) Redesign: change the filters style (#11049) Redesign: secondary actions (#11067) Redesign: assembly members page (#10992) Redesign: update default static map size to 300px (#10953) Redesign: visual placeholder cards (#11038) Redesign: fix emoji popup position (#10957) Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983) Redesign: opinion buttons (#10998) Display a disabled message button in public profile if user blocks them instead of hidding it (#10984) Redesign: confirm modal Foundation-free (#10978) Redesign: initiatives (#10646) Redesign: surveys (#10922) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR replaces the scopes picker in the front with a select. The admin scopes picker remains because some test break using the select
📌 Related Issues
Link your PR to an issue
Testing
Enabe scopes in a participatory space and make sure to select a scope with child scopes. Create or update inside the space a Proposals space and enable also participatory space with the same scope than the space. Configure also the space to allow users creation of proposals in front. As user create a proposal and check the presence of the scope select
Signed in as admin@example.org visit https://decidim-redesign.populate.tools/processes/Decidim4Dummies/f/1941/proposals/17400/complete
📷 Screenshots