Conversation
|
Meetings and Surveys specs are failing due to a shared test solved in #10886 |
There was a problem hiding this comment.
Hi @Crashillo, thanks for the job!
Just a couple of things:
- Uploading files is not working. I can click on the button and select a file, but it's not uploaded.
- In matrix questions with shorts statements, the table is so small. We need to define a minimum width of the columns.
See the same question in redesign:
And in 0.27:
- I have the feeling that there is a lot of blank space. Maybe we can think about compressing the sections a bit more.
* feature/redesign: Redesign: amendments (#10765)
I'm gonna do slightly changes on the position of certain elements (e.g. https://decidim-redesign.populate.tools/users/sign_up), and I'll compress a bit the part beneath the grey bar... but the title-description block has to remain as it is, since is the normal spacing all along the application |
|
As we have already agreed, we'll work on design details, including spacing,
in the coming weeks. Let's not spend time with this now. Thanks.
|
There was a problem hiding this comment.
Hi @Crashillo!
Looks good to me now, just one thing:
- If I try to submit my answers and I get an error, then when I try again to answer the survey the submit button is not working.
Okey @furilo we can leave this details for the final sprint. I'll open an issue
I cannot reproduce it. Look at this survey: https://decidim-redesign.populate.tools/processes/eix-lab/f/1935/surveys/289 Try again there o share where that was happening |
There was a problem hiding this comment.
-
The close button of the confirm modal is not working. See video:
https://www.awesomescreenshot.com/video/18178087?key=b10506ae4e6f9caa3b82d678b342fc30 -
The Add files button is not being displayed, only when you hover it appears. This is also happening with the cookies buttons.
|
Both things are being handled apart:
They're cross features, don't exclusively from surveys, hence we manage them somewhere else |
alecslupu
left a comment
There was a problem hiding this comment.
LGTM from the code perspective. I need to test it on my local.
alecslupu
left a comment
There was a problem hiding this comment.
LGTM. Checked on localhost and looks ok.
…ations * feature/redesign: (78 commits) Redesign: initiatives (#10646) Redesign: surveys (#10922) Redesign: coauthors (#10954) remove font-bold from breadcrumb (#10990) Redesign: participatory texts (#10941) Redesign: budgets (#10195) Redesign: fix buttons & geocoder (#10975) Unskip tests (#10951) Fix failing specs Redesign sortitions (#10831) Redesign: data toggle (#10886) Redesign: collaborative drafts (#10729) Redesign: pending pages (#10944) Redesign: my account (#10904) use foundation classes instead of default html validation (#10921) Fix failings redesign specs Add gitpod support (#10641) Fix pipeline after #10409 (#10670) Upgrade webpack and other javascript libraries (#10643) New Crowdin updates (#10409) ...
* feature/redesign: (26 commits) Use the component name in the sidebar title (#11088) Redesign: layout center (#11068) Redesign: display only public users followings in following profile tab (#11051) Redesign: fix cards (#11072) Redesign: remove gcalendar warning (#10999) lock sass-embedded (#11077) Redesign: scopes picker (#11039) Redesign: pending notifications (#10926) Redesign: change the filters style (#11049) Redesign: secondary actions (#11067) Redesign: assembly members page (#10992) Redesign: update default static map size to 300px (#10953) Redesign: visual placeholder cards (#11038) Redesign: fix emoji popup position (#10957) Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983) Redesign: opinion buttons (#10998) Display a disabled message button in public profile if user blocks them instead of hidding it (#10984) Redesign: confirm modal Foundation-free (#10978) Redesign: initiatives (#10646) Redesign: surveys (#10922) ...
🎩 What? Why?
Fix the pending about the replacement of the data-toggle for decidim-forms. This PR expects #10886 to be working, so it won't do anything on its own.
📌 Related Issues
📷 Screenshots
https://decidim-redesign.populate.tools/processes/eix-lab/f/232/ (need to be admin to see this)