Skip to content

Redesign: update default static map size to 300px#10953

Merged
ferblape merged 5 commits intofeature/redesignfrom
fix/static-map-size-10145
Jun 19, 2023
Merged

Redesign: update default static map size to 300px#10953
ferblape merged 5 commits intofeature/redesignfrom
fix/static-map-size-10145

Conversation

@ferblape
Copy link
Copy Markdown
Contributor

@ferblape ferblape commented Jun 6, 2023

🎩 What? Why?

This PR:

  • updates static maps default size to 300px, to adapt to the new design
  • refactors the default size and default zoom, extracting them to constants, so future updates will be easier

📌 Related Issues

Testing

📷 Screenshots

Screenshot 2023-06-06 at 06 48 23

♥️ Thank you!

@ferblape ferblape changed the base branch from develop to feature/redesign June 6, 2023 04:49
@alecslupu alecslupu added the project: redesign Barcelona City Council contract label Jun 6, 2023
@andreslucena andreslucena changed the title Redesign / Update default static map size to 300px Redesign: update default static map size to 300px Jun 6, 2023
@ferblape ferblape requested a review from a team June 6, 2023 08:38
@andreslucena
Copy link
Copy Markdown
Member

@ferblape seems like it isn't showing the marker at the middle. It's probably because we're showing a square image in a rectangle. If you go to the admin, in the Manage Meetings page, you can see the marker. Can you fix that?

@ferblape
Copy link
Copy Markdown
Contributor Author

ferblape commented Jun 7, 2023

@andreslucena fixed!

Copy link
Copy Markdown
Member

@carolromero carolromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ferblape!

@ferblape ferblape requested a review from a team June 8, 2023 18:14
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:
image

After:
image

@alecslupu
Copy link
Copy Markdown
Contributor

As a side note, when clicking on the map marker, the html is being displayed
image

@ferblape ferblape merged commit a6730bf into feature/redesign Jun 19, 2023
@ferblape ferblape deleted the fix/static-map-size-10145 branch June 19, 2023 09:45
entantoencuanto added a commit that referenced this pull request Jun 20, 2023
* feature/redesign:
  Redesign: change the filters style (#11049)
  Redesign: secondary actions (#11067)
  Redesign: assembly members page (#10992)
  Redesign: update default static map size to 300px (#10953)
  Redesign: visual placeholder cards (#11038)
  Redesign: fix emoji popup position (#10957)
  Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983)
  Redesign: opinion buttons (#10998)
  Display a disabled message button in public profile if user blocks them instead of hidding it (#10984)
  Redesign: confirm modal Foundation-free (#10978)
entantoencuanto added a commit that referenced this pull request Jun 23, 2023
* feature/redesign: (26 commits)
  Use the component name in the sidebar title (#11088)
  Redesign: layout center (#11068)
  Redesign: display only public users followings in following profile tab (#11051)
  Redesign: fix cards (#11072)
  Redesign: remove gcalendar warning (#10999)
  lock sass-embedded (#11077)
  Redesign: scopes picker (#11039)
  Redesign: pending notifications (#10926)
  Redesign: change the filters style (#11049)
  Redesign: secondary actions (#11067)
  Redesign: assembly members page (#10992)
  Redesign: update default static map size to 300px (#10953)
  Redesign: visual placeholder cards (#11038)
  Redesign: fix emoji popup position (#10957)
  Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983)
  Redesign: opinion buttons (#10998)
  Display a disabled message button in public profile if user blocks them instead of hidding it (#10984)
  Redesign: confirm modal Foundation-free (#10978)
  Redesign: initiatives (#10646)
  Redesign: surveys (#10922)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

HERE Maps static map size

4 participants