Redesign: fix emoji popup position#10957
Merged
ferblape merged 6 commits intofeature/redesignfrom Jun 18, 2023
Merged
Conversation
48220d4 to
b08502b
Compare
furilo
approved these changes
Jun 7, 2023
Contributor
|
@Crashillo in mobile the selector should be slightly adjusted:
|
b08502b to
720bdb0
Compare
Contributor
|
There's a failing spec about the spellchecker I can barely understand (it's not related w/ this). Do you know anything about it @alecslupu? |
alecslupu
suggested changes
Jun 13, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
LGTM
On a second thought ... on mobile i would add some margins for the modal on the mobile. I had several issues closing the emoji picker:
7e07bcd to
d37b170
Compare
entantoencuanto
added a commit
that referenced
this pull request
Jun 20, 2023
* feature/redesign: Redesign: change the filters style (#11049) Redesign: secondary actions (#11067) Redesign: assembly members page (#10992) Redesign: update default static map size to 300px (#10953) Redesign: visual placeholder cards (#11038) Redesign: fix emoji popup position (#10957) Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983) Redesign: opinion buttons (#10998) Display a disabled message button in public profile if user blocks them instead of hidding it (#10984) Redesign: confirm modal Foundation-free (#10978)
entantoencuanto
added a commit
that referenced
this pull request
Jun 23, 2023
* feature/redesign: (26 commits) Use the component name in the sidebar title (#11088) Redesign: layout center (#11068) Redesign: display only public users followings in following profile tab (#11051) Redesign: fix cards (#11072) Redesign: remove gcalendar warning (#10999) lock sass-embedded (#11077) Redesign: scopes picker (#11039) Redesign: pending notifications (#10926) Redesign: change the filters style (#11049) Redesign: secondary actions (#11067) Redesign: assembly members page (#10992) Redesign: update default static map size to 300px (#10953) Redesign: visual placeholder cards (#11038) Redesign: fix emoji popup position (#10957) Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983) Redesign: opinion buttons (#10998) Display a disabled message button in public profile if user blocks them instead of hidding it (#10984) Redesign: confirm modal Foundation-free (#10978) Redesign: initiatives (#10646) Redesign: surveys (#10922) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR fixes the emoji popup position by just upgrading the package version, because it was an error in the library joeattardi/picmo#259
📌 Related Issues
Testing
📷 Screenshots