Skip to content

Redesign: layout center#11068

Merged
ferblape merged 11 commits intofeature/redesignfrom
feature/redesign-layout-center
Jun 23, 2023
Merged

Redesign: layout center#11068
ferblape merged 11 commits intofeature/redesignfrom
feature/redesign-layout-center

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented Jun 19, 2023

🎩 What? Why?

Refactor of the layout_center to simplify the DOM elements and do not nest grids. Apply this layout to the public profile as well.

📌 Related Issues

📷 Screenshots

♥️ Thank you!

@Crashillo Crashillo added the project: redesign Barcelona City Council contract label Jun 19, 2023
@Crashillo Crashillo linked an issue Jun 19, 2023 that may be closed by this pull request
@Crashillo Crashillo requested review from ferblape and furilo June 19, 2023 15:32
@furilo
Copy link
Copy Markdown
Contributor

furilo commented Jun 19, 2023

Let's make the Profile 10 cols, as Account

@furilo furilo requested a review from a team June 20, 2023 20:10
@furilo
Copy link
Copy Markdown
Contributor

furilo commented Jun 20, 2023

@decidim/product This is something mostly technical

Copy link
Copy Markdown
Member

@carolromero carolromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it quickly, it looks ok. I'll leave this to maintainers.

@ferblape ferblape requested a review from fblupi June 22, 2023 08:03
@fblupi fblupi self-requested a review June 22, 2023 16:14
@ferblape ferblape requested a review from fblupi June 23, 2023 04:05
@ferblape ferblape merged commit b013b32 into feature/redesign Jun 23, 2023
@ferblape ferblape deleted the feature/redesign-layout-center branch June 23, 2023 06:12
entantoencuanto added a commit that referenced this pull request Jun 23, 2023
* feature/redesign: (26 commits)
  Use the component name in the sidebar title (#11088)
  Redesign: layout center (#11068)
  Redesign: display only public users followings in following profile tab (#11051)
  Redesign: fix cards (#11072)
  Redesign: remove gcalendar warning (#10999)
  lock sass-embedded (#11077)
  Redesign: scopes picker (#11039)
  Redesign: pending notifications (#10926)
  Redesign: change the filters style (#11049)
  Redesign: secondary actions (#11067)
  Redesign: assembly members page (#10992)
  Redesign: update default static map size to 300px (#10953)
  Redesign: visual placeholder cards (#11038)
  Redesign: fix emoji popup position (#10957)
  Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983)
  Redesign: opinion buttons (#10998)
  Display a disabled message button in public profile if user blocks them instead of hidding it (#10984)
  Redesign: confirm modal Foundation-free (#10978)
  Redesign: initiatives (#10646)
  Redesign: surveys (#10922)
  ...
ferblape added a commit that referenced this pull request Jun 26, 2023
* simplify layout center

* use cols-8 layout for public profile

* span to 10 cols

* Simplify code

* Restore conditional

* Revert "Restore conditional"

This reverts commit a7661bb.

* Revert "Simplify code"

This reverts commit a3db3dc.

* Add clarification

* Use case to check conditions

* Offense

---------

Co-authored-by: Fernando Blat <fernando@blat.es>
entantoencuanto added a commit that referenced this pull request Jun 30, 2023
…-process

* feature/redesign:
  Redesign: display online meeting (#11075)
  Redesign: home menu content block (#11048)
  Redesign: home (#10920)
  Remove widgets and embeds (#11096)
  Redesign / Complete card G cell specs (#11094)
  Redesign: processes assemblies metadata content blocks (#10637)
  Redesign: vertical margin inside the callouts (#11071)
  Redesign / Update package-lock  (#11091)
  Use the component name in the sidebar title (#11088)
  Redesign: layout center (#11068)
  Redesign: display only public users followings in following profile tab (#11051)
  Redesign: fix cards (#11072)
ferblape added a commit that referenced this pull request Jul 1, 2023
…11093)

* Add highlighted process in menu

* Integrate last activity

* do not test the css

* simplify markup

* css tweaks

* wrap metadata in cards

* Redesign: fix cards (#11072)

* small tweaks for process/assembly cards

* remove upcoming meeting from assembly card

* assembly card no longer show upcoming meeting

* Redesign: display only public users followings in following profile tab (#11051)

* Display only public users followings in following profile tab

* Force use of redesigned profile cell

* Fix followings counters to consider only users and groups and fix officialization_text

* Use link for personal url in profile

* Remove deprecated examples

* Change expected texts

* Adapt tests of follows

* Add REDESIGN_PENDING skip

* Add cell spec for redesigned_profile_cell

* Fix spelling

* Adapt tests to redesigned profile

* Remove deprecated examples

* Prepare profile actions buttons to use options

* Add missing resend email confirmation instructions button

* Display user_profile_bottom hook in redesigned profile cell

* Make profile_holder redesigned profile cell public available from hook

* Change styles of member_of user_profile partial

* Recover test

* simplify markup

* add separator

* Fix typo

Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>

---------

Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>

* Redesign: layout center (#11068)

* simplify layout center

* use cols-8 layout for public profile

* span to 10 cols

* Simplify code

* Restore conditional

* Revert "Restore conditional"

This reverts commit a7661bb.

* Revert "Simplify code"

This reverts commit a3db3dc.

* Add clarification

* Use case to check conditions

* Offense

---------

Co-authored-by: Fernando Blat <fernando@blat.es>

* Use the component name in the sidebar title (#11088)

* Use the component name in the sidebar title

* Control when current_component is not defined

* Test component name in the sidebar

* Discard conferences behaviour

* Redesign / Update package-lock  (#11091)

* Update package lock

* Update package lock in design app

* Check model presence

* Offenses

* Offenses

* Update decidim-core/app/views/layouts/decidim/header/_redesigned_menu_breadcrumb_main_dropdown.html.erb

Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>

* Remove deprecated REDESIGN_PENDING comment

---------

Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
Co-authored-by: Eduardo Martínez <eduardomech@gmail.com>
Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Redesign: simplify grid for layout_center

5 participants