Merged
Conversation
…into feature/redesign-home
…cidim into feature/redesign-home
Contributor
|
Ping @decidim/product |
NilHomedes
requested changes
Jun 23, 2023
Member
There was a problem hiding this comment.
Hi @jorgeatgu, I found more things once reviewed again, here we go:
Sub hero banner and footer sub hero banner
- Sub hero footer, add some space between the text and CTA
- I see different text sizes between the two content blocks
Initiatives cards
- Could we get rid of the label
Publlishedin the cards? So as we simplify the information presented in the card. Maybe we can open another issue for that to move on with that PR.
Contributor
Author
@NilHomedes better in a new issue so as not to block this one. One question, just remove the |
…into feature/redesign-home
NilHomedes
approved these changes
Jun 27, 2023
Member
NilHomedes
left a comment
There was a problem hiding this comment.
LGTM 👌
I'll open an issue for initiatives cards
fblupi
requested changes
Jun 27, 2023
Member
fblupi
left a comment
There was a problem hiding this comment.
It's out of scope but we should do anything with the map when the configuration is not defined. It takes up some blank space for the map to be displayed and maybe we should show a kind of announcement: "Map provider not defined" or just remove this space. I don't know what you think @decidim/product
decidim-assemblies/app/cells/decidim/assemblies/content_blocks/highlighted_assemblies_cell.rb
Outdated
Show resolved
Hide resolved
...dim-conferences/app/cells/decidim/conferences/content_blocks/highlighted_conferences_cell.rb
Outdated
Show resolved
Hide resolved
decidim-meetings/app/cells/decidim/meetings/content_blocks/highlighted_meetings_cell.rb
Outdated
Show resolved
Hide resolved
decidim-core/app/cells/decidim/content_blocks/how_to_participate/show.erb
Show resolved
Hide resolved
decidim-core/app/cells/decidim/content_blocks/highlighted_participatory_spaces_cell.rb
Outdated
Show resolved
Hide resolved
...esses/app/cells/decidim/participatory_processes/content_blocks/highlighted_processes_cell.rb
Outdated
Show resolved
Hide resolved
...esses/app/cells/decidim/participatory_processes/content_blocks/highlighted_processes_cell.rb
Show resolved
Hide resolved
decidim-core/app/cells/decidim/content_blocks/highlighted_participatory_spaces_cell.rb
Outdated
Show resolved
Hide resolved
decidim-core/app/cells/decidim/content_blocks/organization_metrics_cell.rb
Outdated
Show resolved
Hide resolved
decidim-core/app/cells/decidim/content_blocks/participatory_space_metrics_cell.rb
Show resolved
Hide resolved
Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>
* Define a method in area presenter to include area type in name if present * Refactor description view in processes to use a presenter * Add description view to assemblies and link from main data content block * Replace start_date and end_date items by date_range in process about page * Add duration and closing date elements to assembly about page * Normalize assemblies translations * move style form about page to core * Fix sanitizer on description pages to allow embedded videos * Add tests for description pages * Adapt triggerWarnings method used when iframes are present to redesign * Rename metadata content blocks in participatory spaces and groups * Define and register metadata content blocks on assemblies and processes * Include full description in main data cell * Remove link to about page in main data content block * Remove description paths, actions, views and references on assemblies and participatory processes * Skip REDESIGN_PENDING tests of description pages pending to adapt to content blocks * Remove unused translation * Add description attributes of metadata content blocks to ignore_unused * add grid for metadata block * fix style glitches on modal steps * wrap description with a show more/less content * Add missing translations taken fron announcement with truncation branch * remove possible margin top of first childs * Include purpose_of_action, internal_organisation and composition in main data of assemblies * Fix assembly type item in extra data content block * Fix date format * Split assemblies metadata content block in two content blocks * Remove date range from metadata participatory processes content block * Extract social handler links to a content block * Include missing content block in test * Remove duration from assemblies dates metadata content block * Remove unused translation * Update decidim-assemblies/app/cells/decidim/assemblies/content_blocks/main_data_cell.rb Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com> * Update decidim-assemblies/app/cells/decidim/assemblies/content_blocks/main_data_cell.rb Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com> * Change endless method definitions * Use a presented assembly in extra data content block --------- Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com> Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>
* Complete Cell G specs * Cleanup specs
Contributor
|
@fblupi feedback applied! |
Member
|
@fblupi thanks for the catch! Not sure what's the current behaviour, but I'd just remove the blank space in case it's not configured. |
Contributor
|
I'll open an issue for this since its not critical, so we can close this PR: #11102 |
entantoencuanto
added a commit
that referenced
this pull request
Jun 28, 2023
* feature/redesign: Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088)
entantoencuanto
added a commit
that referenced
this pull request
Jun 28, 2023
* feature/redesign: Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088)
entantoencuanto
added a commit
that referenced
this pull request
Jun 30, 2023
…-process * feature/redesign: Redesign: display online meeting (#11075) Redesign: home menu content block (#11048) Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088) Redesign: layout center (#11068) Redesign: display only public users followings in following profile tab (#11051) Redesign: fix cards (#11072)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR implements the redesign in home:
📌 Related Issues
Testing