Redesign: integrate highlighted process and last activities in menu#11093
Merged
ferblape merged 17 commits intofeature/redesignfrom Jul 1, 2023
Merged
Redesign: integrate highlighted process and last activities in menu#11093ferblape merged 17 commits intofeature/redesignfrom
ferblape merged 17 commits intofeature/redesignfrom
Conversation
de1099d to
376b7fb
Compare
Contributor
|
@Crashillo there are a couple of details that should be reviewed:
|
* small tweaks for process/assembly cards * remove upcoming meeting from assembly card * assembly card no longer show upcoming meeting
…ab (#11051) * Display only public users followings in following profile tab * Force use of redesigned profile cell * Fix followings counters to consider only users and groups and fix officialization_text * Use link for personal url in profile * Remove deprecated examples * Change expected texts * Adapt tests of follows * Add REDESIGN_PENDING skip * Add cell spec for redesigned_profile_cell * Fix spelling * Adapt tests to redesigned profile * Remove deprecated examples * Prepare profile actions buttons to use options * Add missing resend email confirmation instructions button * Display user_profile_bottom hook in redesigned profile cell * Make profile_holder redesigned profile cell public available from hook * Change styles of member_of user_profile partial * Recover test * simplify markup * add separator * Fix typo Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com> --------- Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com> Co-authored-by: Fernando Blat <fernando@blat.es> Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>
* simplify layout center * use cols-8 layout for public profile * span to 10 cols * Simplify code * Restore conditional * Revert "Restore conditional" This reverts commit a7661bb. * Revert "Simplify code" This reverts commit a3db3dc. * Add clarification * Use case to check conditions * Offense --------- Co-authored-by: Fernando Blat <fernando@blat.es>
* Use the component name in the sidebar title * Control when current_component is not defined * Test component name in the sidebar * Discard conferences behaviour
* Update package lock * Update package lock in design app
Contributor
|
@entantoencuanto a last detail: I've realized that if you are in a space and open the Home/General Dropdown, the Last Activity is the same as the one of the Space, not of the whole site 
|
Contributor
|
@fblupi apart from the last comment I added, this can be reviewed. |
fblupi
requested changes
Jun 30, 2023
...dim-core/app/views/layouts/decidim/header/_redesigned_menu_breadcrumb_main_dropdown.html.erb
Outdated
Show resolved
Hide resolved
…_breadcrumb_main_dropdown.html.erb Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>
…-process * feature/redesign: Redesign: display online meeting (#11075) Redesign: home menu content block (#11048) Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088) Redesign: layout center (#11068) Redesign: display only public users followings in following profile tab (#11051) Redesign: fix cards (#11072)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR completes the integration of the menu highlighted process and last activities.
📌 Related Issues
Testing
Check that:
📷 Screenshots