Redesign: assembly members page#10992
Merged
ferblape merged 22 commits intofeature/redesignfrom Jun 20, 2023
Merged
Conversation
…into feature/redesign-assembly-members-page
…ng non_user_avatar if required
…into feature/redesign-assembly-members-page
carolromero
requested changes
Jun 15, 2023
Member
There was a problem hiding this comment.
@jorgeatgu some feedback from the review:
- change counter style to match the other counters
-
change font size to match 'designated on'
-
I get an error when filling the field 'ceased date': https://decidim-redesign.populate.tools/assemblies/first-generation/members
Contributor
Author
|
first and second done @carolromero
In try.decidim, the member's page also is unavailable if all the assembly members are ceased. assembly-members.mov |
carolromero
approved these changes
Jun 16, 2023
Member
carolromero
left a comment
There was a problem hiding this comment.
In try.decidim, the member's page also is unavailable if all the assembly members are ceased.
I'll report the bug, thanks
alecslupu
suggested changes
Jun 17, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
I have a small change that i would do regarding the Look and feel of the header.
decidim-assemblies/app/views/decidim/assemblies/assembly_members/index.html.erb
Outdated
Show resolved
Hide resolved
decidim-assemblies/app/cells/decidim/assemblies/assembly_member/show.erb
Show resolved
Hide resolved
Contributor
|
@entantoencuanto there is a Lint error. Could you have a look on it? |
357a3af to
a0a8d03
Compare
entantoencuanto
added a commit
that referenced
this pull request
Jun 20, 2023
* feature/redesign: Redesign: change the filters style (#11049) Redesign: secondary actions (#11067) Redesign: assembly members page (#10992) Redesign: update default static map size to 300px (#10953) Redesign: visual placeholder cards (#11038) Redesign: fix emoji popup position (#10957) Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983) Redesign: opinion buttons (#10998) Display a disabled message button in public profile if user blocks them instead of hidding it (#10984) Redesign: confirm modal Foundation-free (#10978)
entantoencuanto
added a commit
that referenced
this pull request
Jun 23, 2023
* feature/redesign: (26 commits) Use the component name in the sidebar title (#11088) Redesign: layout center (#11068) Redesign: display only public users followings in following profile tab (#11051) Redesign: fix cards (#11072) Redesign: remove gcalendar warning (#10999) lock sass-embedded (#11077) Redesign: scopes picker (#11039) Redesign: pending notifications (#10926) Redesign: change the filters style (#11049) Redesign: secondary actions (#11067) Redesign: assembly members page (#10992) Redesign: update default static map size to 300px (#10953) Redesign: visual placeholder cards (#11038) Redesign: fix emoji popup position (#10957) Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983) Redesign: opinion buttons (#10998) Display a disabled message button in public profile if user blocks them instead of hidding it (#10984) Redesign: confirm modal Foundation-free (#10978) Redesign: initiatives (#10646) Redesign: surveys (#10922) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR implements the redesign in the assembly members page
📌 Related Issues
Link your PR to an issue
Testing
General Assembly of the Decidim Association