Skip to content

Redesign: participatory texts#10941

Merged
ferblape merged 10 commits intofeature/redesignfrom
feature/redesign-participatory-texts
Jun 14, 2023
Merged

Redesign: participatory texts#10941
ferblape merged 10 commits intofeature/redesignfrom
feature/redesign-participatory-texts

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented May 31, 2023

🎩 What? Why?

Redesign of the participatory texts

📌 Related Issues

📷 Screenshots

https://decidim-redesign.populate.tools/processes/Decidim4Dummies/f/1888/

♥️ Thank you!

@Crashillo Crashillo added the project: redesign Barcelona City Council contract label May 31, 2023
@Crashillo Crashillo changed the title Feature/redesign participatory texts Redesign: participatory texts Jun 1, 2023
@Crashillo Crashillo linked an issue Jun 1, 2023 that may be closed by this pull request
@Crashillo Crashillo marked this pull request as ready for review June 1, 2023 09:42
@Crashillo Crashillo requested review from ferblape and furilo June 1, 2023 09:42
@Crashillo Crashillo force-pushed the feature/redesign-participatory-texts branch from 2bb1ce1 to db510b9 Compare June 1, 2023 09:48
@furilo
Copy link
Copy Markdown
Contributor

furilo commented Jun 2, 2023

@decidim/product ready to review.

You'll notice there is a slight difference of this relative to the design. The reason is this component is being used in other places, so to maintain consistency we'd keep the implemented version.

image

@furilo furilo requested a review from a team June 5, 2023 08:21
@Crashillo Crashillo force-pushed the feature/redesign-participatory-texts branch from 3675276 to 00d2033 Compare June 8, 2023 11:21
Copy link
Copy Markdown
Member

@NilHomedes NilHomedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Crashillo I'll leave my review.
As we are going to rethink the whole feature in the near future, we are not going to spend to much time in this design for the moment.

Just one thing:

  • Could we remove the follow button from the participatory text view? I think that here the primary actions are amend and comment, but following the proposal should not be at the same level.

Screenshot 2023-06-09 at 10-50-33 Metadecidim

@Crashillo Crashillo requested a review from NilHomedes June 9, 2023 12:27
Copy link
Copy Markdown
Member

@NilHomedes NilHomedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ferblape ferblape requested a review from a team June 13, 2023 03:41
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@ferblape ferblape merged commit 785ffae into feature/redesign Jun 14, 2023
@ferblape ferblape deleted the feature/redesign-participatory-texts branch June 14, 2023 04:19
entantoencuanto added a commit that referenced this pull request Jun 14, 2023
* feature/redesign:
  Redesign: surveys (#10922)
  Redesign: coauthors (#10954)
  remove font-bold from breadcrumb (#10990)
  Redesign: participatory texts (#10941)
  Redesign: budgets (#10195)
  Redesign: fix buttons & geocoder (#10975)
  Unskip tests (#10951)
entantoencuanto added a commit that referenced this pull request Jun 14, 2023
* feature/redesign:
  Redesign: surveys (#10922)
  Redesign: coauthors (#10954)
  remove font-bold from breadcrumb (#10990)
  Redesign: participatory texts (#10941)
entantoencuanto added a commit that referenced this pull request Jun 15, 2023
…ations

* feature/redesign: (78 commits)
  Redesign: initiatives (#10646)
  Redesign: surveys (#10922)
  Redesign: coauthors (#10954)
  remove font-bold from breadcrumb (#10990)
  Redesign: participatory texts (#10941)
  Redesign: budgets (#10195)
  Redesign: fix buttons & geocoder (#10975)
  Unskip tests (#10951)
  Fix failing specs
  Redesign sortitions (#10831)
  Redesign: data toggle (#10886)
  Redesign: collaborative drafts (#10729)
  Redesign: pending pages (#10944)
  Redesign: my account (#10904)
  use foundation classes instead of default html validation (#10921)
  Fix failings redesign specs
  Add gitpod support (#10641)
  Fix pipeline after #10409 (#10670)
  Upgrade webpack and other javascript libraries (#10643)
  New Crowdin updates (#10409)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Redesign / Participatory texts

6 participants