Skip to content

CPTs: Add support for excerpts in portfolios/testimonials#8707

Merged
oskosk merged 2 commits intomasterfrom
kraftbj-patch-3
Feb 6, 2018
Merged

CPTs: Add support for excerpts in portfolios/testimonials#8707
oskosk merged 2 commits intomasterfrom
kraftbj-patch-3

Conversation

@kraftbj
Copy link
Copy Markdown
Contributor

@kraftbj kraftbj commented Feb 1, 2018

In #2815, we added support to show either the full content or the excerpt, but this CPT doesn't support a custom excerpt.

918124-zen

Changelog entry

  • We added support for excerpts on Testimonial and Portfolio custom post types.

@kraftbj kraftbj requested a review from a team as a code owner February 1, 2018 15:02
@kraftbj kraftbj added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Custom Content Types Custom post or content types (usually for testimonials and portfolios) and their settings. [Status] Needs Review This PR is ready for review. [Pri] Normal labels Feb 1, 2018
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good idea. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 1, 2018
@oskosk oskosk added this to the 5.9 milestone Feb 6, 2018
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well!

@oskosk oskosk merged commit 74bfe9b into master Feb 6, 2018
@oskosk oskosk deleted the kraftbj-patch-3 branch February 6, 2018 18:35
@oskosk oskosk removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 6, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Custom Content Types Custom post or content types (usually for testimonials and portfolios) and their settings. [Pri] Normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants