Skip to content

Added suppress_filters param to get_posts / get_children function calls.#8625

Merged
zinigor merged 1 commit intoAutomattic:masterfrom
spacedmonkey:suppress_filters
Feb 27, 2018
Merged

Added suppress_filters param to get_posts / get_children function calls.#8625
zinigor merged 1 commit intoAutomattic:masterfrom
spacedmonkey:suppress_filters

Conversation

@spacedmonkey
Copy link
Copy Markdown
Contributor

@spacedmonkey spacedmonkey commented Jan 26, 2018

Fixes #8624

Changes proposed in this Pull Request:

  • Pass suppress_filters to all public facing calls to get_posts / get_children

Testing instructions:

  • This is hard to test. There should be no noticeable difference it it works.

Proposed changelog entry for your changes:

Added suppress_filters param to get_posts / get_children function calls.

@spacedmonkey spacedmonkey requested a review from a team as a code owner January 26, 2018 12:58
@zinigor
Copy link
Copy Markdown
Contributor

zinigor commented Jan 26, 2018

Thanks for the contribution!
You are saying that this is hard to test, but in the issue you have provided examples of plugins that may rely on filters not being suppressed. You probably had one or two cases where this change would fix a problem. Can you at least describe that case? Otherwise if it makes almost no difference, as you say, we don't see why it needs to get in.

@zinigor zinigor added General [Status] Needs Review This PR is ready for review. [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Jan 26, 2018
@spacedmonkey
Copy link
Copy Markdown
Contributor Author

spacedmonkey commented Jan 26, 2018

Thanks for getting back. Advanced post cache is the perfect example of a use cache then. Out of the box, WP_Query runs a couple of queries and these are uncached. Advanced post cache, used on all WordPress.com sites (even GO VIP), hooks into WP_Query can caches the result of these queries to stop the running on every page load. With this suppress_filtersadvanced post cache doesn't not run. This means queries run unnecessarily and result in high level of traffic to database servers at peak times.

Take for example this query that is running on production.
screenshot from 2018-01-26 14-32-03
This query should be cached, specially because it is a LIKE search.

It is hard to test because you have to be running another plugin to take advantage of the performance win here.

@zinigor zinigor added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jan 26, 2018
dereksmart
dereksmart approved these changes Feb 20, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds reasonable 👍

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 20, 2018
@oskosk oskosk added this to the 5.9 milestone Feb 23, 2018
@zinigor zinigor merged commit d7d094c into Automattic:master Feb 27, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
@oskosk
Add changelog entry for #8625
80ec0c7
oskosk added a commit that referenced this pull request Feb 27, 2018
@oskosk
Changelog 5.9: running changelog (#8819)
1174ef5 
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
@dereksmart dereksmart mentioned this pull request Apr 19, 2018
Merged
@kraftbj kraftbj mentioned this pull request Oct 9, 2019
Closed
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dereksmart dereksmart dereksmart approved these changes

Assignees

No one assigned

Labels

[Focus] Performance General Touches WP.com Files

Projects

None yet

Milestone

5.9

Development

Successfully merging this pull request may close these issues.

Pass suppress_filters param to all get_posts calls

7 participants

@spacedmonkey @zinigor @dereksmart @kraftbj @jeherve @oskosk @matticbot