Skip to content

API: Jetpack: API: Updates /sites/%s/jetpack/modules endpoints respon…#8863

Merged
dereksmart merged 1 commit intomasterfrom
sync/ebinnion/r170223-wpcom-1518815965
Feb 21, 2018
Merged

API: Jetpack: API: Updates /sites/%s/jetpack/modules endpoints respon…#8863
dereksmart merged 1 commit intomasterfrom
sync/ebinnion/r170223-wpcom-1518815965

Conversation

@ebinnion
Copy link
Copy Markdown
Contributor

@ebinnion ebinnion commented Feb 16, 2018

…se format to add override

Currently, it is possible to override the active modules in Jetpack and force some to be active or inactive. The issue with this is that our UI does not respond to that. So, while a module may be forced on, a user is shown UI that allows them to attempt to disable the module, except, when the page is refreshed, the module is still enabled.

See: #8836
See: #8800

Differential Revision: D10224-code

This commit syncs r170223-wpcom.

Fixes #

Changes proposed in this Pull Request:

Testing instructions:

Proposed changelog entry for your changes:

  • We made Jetpack's JSON API endpoint for modules now reply with a new property override that indicates if a module was either enabled or disabled by a filter.

…se format to add override

Currently, it is possible to override the active modules in Jetpack and force some to be active or inactive. The issue with this is that our UI does not respond to that. So, while a module may be forced on, a user is shown UI that allows them to attempt to disable the module, except, when the page is refreshed, the module is still enabled.

See: #8836
See: #8800

Differential Revision: D10224-code

This commit syncs r170223-wpcom.
@ebinnion ebinnion added this to the 5.9 milestone Feb 16, 2018
@ebinnion ebinnion self-assigned this Feb 16, 2018
@ebinnion ebinnion requested a review from a team as a code owner February 16, 2018 21:20
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 19, 2018
@dereksmart dereksmart merged commit b5f2e25 into master Feb 21, 2018
@dereksmart dereksmart deleted the sync/ebinnion/r170223-wpcom-1518815965 branch February 21, 2018 22:36
oskosk added a commit that referenced this pull request Feb 27, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants