Plans in Plugin: correctly forward the client IP for currency localization#8930
Merged
Plans in Plugin: correctly forward the client IP for currency localization#8930
Conversation
Follows on from #8834
withinboredom
suggested changes
Feb 23, 2018
Contributor
withinboredom
left a comment
There was a problem hiding this comment.
We should keep X_FORWARDED_FOR and CLIENT_IP headers because a lot of hosts probably have load balancers in front of their servers. Especially places like GC, AWS, etc.
| // no ip list to forward, so create one: | ||
| $ip = $_SERVER['HTTP_CLIENT_IP']; | ||
| } | ||
| // passing along from client to help geolocate currency |
Contributor
There was a problem hiding this comment.
You probably want to start with X_FORWARDED_FOR in case there's a load balancer in front of the site (like cloudflare, AWS)
| $ip = $_SERVER['HTTP_CLIENT_IP']; | ||
| } | ||
| // passing along from client to help geolocate currency | ||
| $ip = $_SERVER['REMOTE_ADDR']; |
Contributor
There was a problem hiding this comment.
HTTP_CLIENT_IP is another proxy var that might be set ... I completely forget about REMOTE_ADDR (it's not applicable to my test site, so overlooked it)
jeherve
reviewed
Feb 24, 2018
Member
jeherve
left a comment
There was a problem hiding this comment.
Should we rely on the data we get and store for Protect in here? It may provide us with at reliable IP address?
See the trusted_ip_header option for example.
withinboredom
approved these changes
Feb 26, 2018
Contributor
Author
|
haha, I was just working on the same thing, thanks |
oskosk
added a commit
that referenced
this pull request
Feb 27, 2018
oskosk
added a commit
that referenced
this pull request
Feb 27, 2018
* update changelog.txt * Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink * Add changelog entry for #8243 * Add changelog entry for #8296 * Add changelog entry for #8367 * Add changelog entry for #8686 * Add changelog entry for #8707 * Add changelog entry for #8709 and #8714 * Add changelog entry for #8729 * Add changelog entry for #8777 * Add changelog entry for #8780 * Add changelog entry for #8786 * Add changelog entry for #8787 * Add changelog entry for #8801 #8805 #8832 #8865 and #8804 * Add changelog entry for #8817 * Add changelog entry for #8822 * Add changelog entry for #8823 * Add changelog entry for #8829 * Add changelog entry for #8834 * move some items to major enhancements * Add changelog entry for #8836 * Add changelog entry for #8839 * Add changelog entry for #8861 * Add changelog entry for #8862 * Add changelog entry for #8863 * Add changelog entry for #8866 * Add changelog entry for #8870 * Add changelog entry for #8874 * Add changelog entry for #8875 * Add changelog entry for #8881 * Add changelog entry for #8890 * Add changelog entry for #8911 * Add changelog entry for #8927 * Add changelog entry for #8931 * Add changelog entry for #8933 * Add changelog entry for #8930 * fix wording * typo * minor fixes * replace partner scripts for Jetpack Start in changelog entry * Update to-test.md * Update to-test.md * minor style fixes to to-test.md * minor style fixes to to-test.md * minor fixes on to-test.md * Add changelog entry for #8868 * Add changelog entry for #8844 * Add changelog entry for #8664 * Add changelog entry for #8935 * Add changelog entry for #8425 * Add changelog entry for #8625
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows on from #8834
Changes proposed in this Pull Request:
$_SERVERvar from the client so that the wpcom plans endpoint can guess the client's locale and localize the currenctyjetpack_cache_plansfilter returns falseChangelog entry
Plans: correctly forward the client IP for currency localization.