Skip to content

WordAds: Avoid usage of create_function#8870

Merged
oskosk merged 1 commit intomasterfrom
remove/create_function-usage-from-wordads-widget
Feb 19, 2018
Merged

WordAds: Avoid usage of create_function#8870
oskosk merged 1 commit intomasterfrom
remove/create_function-usage-from-wordads-widget

Conversation

@oskosk
Copy link
Copy Markdown
Contributor

@oskosk oskosk commented Feb 17, 2018

Part of #8156.

Fixes https://wordpress.org/support/topic/deprecated-function-create_function-2/

Changes proposed in this Pull Request:

  • Introduces function jetpack_wordads_widgets_init_callback .
  • Replaces usage of create_function for jetpack_wordads_widgets_init_callback as widgets_init callback.

Testing instructions:

Proposed changelog entry for your changes:

  • We updated WordAds code to not use create_function which is getting deprecated in PHP 7.2.

@oskosk oskosk added this to the 5.9 milestone Feb 17, 2018
@oskosk oskosk requested a review from a team as a code owner February 17, 2018 16:36
@jeherve jeherve mentioned this pull request Feb 17, 2018
13 tasks
Copy link
Copy Markdown
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] In Progress labels Feb 19, 2018
@oskosk oskosk merged commit 4124d23 into master Feb 19, 2018
@oskosk oskosk deleted the remove/create_function-usage-from-wordads-widget branch February 19, 2018 16:07
oskosk added a commit that referenced this pull request Feb 27, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants