Skip to content

Sync: Fix Trying to get property of non-object in sync/class.jetpack-sync-module-posts.php#8367

Merged
oskosk merged 1 commit intoAutomattic:masterfrom
Umangvaghela:undefine-index-error
Feb 14, 2018
Merged

Sync: Fix Trying to get property of non-object in sync/class.jetpack-sync-module-posts.php#8367
oskosk merged 1 commit intoAutomattic:masterfrom
Umangvaghela:undefine-index-error

Conversation

@Umangvaghela
Copy link
Copy Markdown
Contributor

@Umangvaghela Umangvaghela commented Dec 15, 2017

Fixes #8137
Fixes #7156

Changes proposed in this Pull Request:

  • In this file directly call $post->post_type so it given error. If We update the code so we overcome the problem.

Testing instructions:

Proposed changelog entry for your changes:

  • We fixed a problem in Jetpack Sync code when trying to get property of non-object the post syncing file.

@Umangvaghela Umangvaghela requested a review from a team as a code owner December 15, 2017 14:27
@Umangvaghela Umangvaghela changed the title Undefine-index-error in sync/class.jetpack-sync-module-posts.php Sync: Undefine-index-error in sync/class.jetpack-sync-module-posts.php Dec 15, 2017
@jeherve jeherve added [Package] Sync [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Dec 15, 2017
@oskosk oskosk changed the title Sync: Undefine-index-error in sync/class.jetpack-sync-module-posts.php Sync: Undefined index error in sync/class.jetpack-sync-module-posts.php Dec 21, 2017
@Automattic Automattic deleted a comment from Umangvaghela Jan 5, 2018
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Jan 9, 2018

@Umangvaghela Any reason why you closed this PR?

@Umangvaghela
Copy link
Copy Markdown
Contributor Author

@jeherve

Sir, nobody can review this PR that's why I close the PR.

@Umangvaghela Umangvaghela reopened this Jan 9, 2018
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Jan 9, 2018

nobody can review this PR that's why I close the PR.

As you can see the PR uses the label "[Status] Needs Review". That means that it is on our roadmap of things to look at. We will look at it and review it at some point in the future, and update this PR when we do so.

Until then, you can leave the PR as it is, you don't need to do anything with it.

Thank you for your patience.

@oskosk oskosk changed the title Sync: Undefined index error in sync/class.jetpack-sync-module-posts.php Sync: Fix Trying to get property of non-object in sync/class.jetpack-sync-module-posts.php Feb 14, 2018
@oskosk oskosk added this to the 5.9 milestone Feb 14, 2018
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!. Closes two issues

@oskosk oskosk merged commit e4477eb into Automattic:master Feb 14, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
@kraftbj kraftbj removed the [Status] Needs Review This PR is ready for review. label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Package] Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undefined index in class.jetpack-sync-functions.php Sync: PHP notice on module-posts

5 participants