Sync: Add action hook to enqueue_action#8829
Merged
jeherve merged 2 commits intoAutomattic:masterfrom Feb 19, 2018
rebeccahum:vip/add_hook_queue_sync
Merged
Sync: Add action hook to enqueue_action#8829jeherve merged 2 commits intoAutomattic:masterfrom rebeccahum:vip/add_hook_queue_sync
jeherve merged 2 commits intoAutomattic:masterfrom
rebeccahum:vip/add_hook_queue_sync
Conversation
jeherve
requested changes
Feb 13, 2018
Member
jeherve
left a comment
There was a problem hiding this comment.
Just a couple of minor changes.
sync/class.jetpack-sync-listener.php
Outdated
| /** | ||
| * Add an action hook to execute when anything on the whitelist gets sent to the queue to sync. | ||
| * | ||
| * @since 5.8 |
Member
There was a problem hiding this comment.
Since 5.8 has already shipped, could you replace with 5.9.0?
Thank you!
| * Add an action hook to execute when anything on the whitelist gets sent to the queue to sync. | ||
| * | ||
| * @since 5.8 | ||
| * |
Member
There was a problem hiding this comment.
Could you add @module sync here? We use this to create categories in our codex:
https://developer.jetpack.com/module/sync/
sync/class.jetpack-sync-listener.php
Outdated
| * | ||
| * @param array The action parameters | ||
| */ | ||
| do_action( "jetpack_action_before_enqueue" ); |
Member
There was a problem hiding this comment.
I think you could use single quotes here. And I would suggest renaming the action to jetpack_sync_action_before_enqueue, so it's a bit more descriptive.
sync/class.jetpack-sync-listener.php
Outdated
| * | ||
| * @since 5.8 | ||
| * | ||
| * @param array The action parameters |
Member
There was a problem hiding this comment.
If you add a parameter here, you will need to pass one to the hook as well.
Contributor
Author
|
@jeherve Thanks! Changes complete. |
oskosk
added a commit
that referenced
this pull request
Feb 27, 2018
oskosk
added a commit
that referenced
this pull request
Feb 27, 2018
* update changelog.txt * Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink * Add changelog entry for #8243 * Add changelog entry for #8296 * Add changelog entry for #8367 * Add changelog entry for #8686 * Add changelog entry for #8707 * Add changelog entry for #8709 and #8714 * Add changelog entry for #8729 * Add changelog entry for #8777 * Add changelog entry for #8780 * Add changelog entry for #8786 * Add changelog entry for #8787 * Add changelog entry for #8801 #8805 #8832 #8865 and #8804 * Add changelog entry for #8817 * Add changelog entry for #8822 * Add changelog entry for #8823 * Add changelog entry for #8829 * Add changelog entry for #8834 * move some items to major enhancements * Add changelog entry for #8836 * Add changelog entry for #8839 * Add changelog entry for #8861 * Add changelog entry for #8862 * Add changelog entry for #8863 * Add changelog entry for #8866 * Add changelog entry for #8870 * Add changelog entry for #8874 * Add changelog entry for #8875 * Add changelog entry for #8881 * Add changelog entry for #8890 * Add changelog entry for #8911 * Add changelog entry for #8927 * Add changelog entry for #8931 * Add changelog entry for #8933 * Add changelog entry for #8930 * fix wording * typo * minor fixes * replace partner scripts for Jetpack Start in changelog entry * Update to-test.md * Update to-test.md * minor style fixes to to-test.md * minor style fixes to to-test.md * minor fixes on to-test.md * Add changelog entry for #8868 * Add changelog entry for #8844 * Add changelog entry for #8664 * Add changelog entry for #8935 * Add changelog entry for #8425 * Add changelog entry for #8625
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this Pull Request:
enqueue_actionwhen anything on the whitelist gets sent to the queue to sync.Testing instructions:
add_action.Changelog entry