Jetpack Start: Allow hosts to pass a tracking ID when provisioning or cancelling a plan#8686
Merged
gravityrail merged 2 commits intomasterfrom Feb 13, 2018
Merged
Conversation
gravityrail
previously requested changes
Feb 13, 2018
class.jetpack-cli.php
Outdated
|
|
||
| $url = sprintf( 'https://%s/rest/v1.3/jpphp/%d/partner-provision', $this->get_api_host(), $blog_id ); | ||
| if ( ! empty( $named_args['host_tracking_id'] ) ) { | ||
| $url = esc_url_raw( add_query_arg( 'host_source_id', $named_args, $url ) ); |
Contributor
There was a problem hiding this comment.
Seems like giving this a different name on WPCOM and Jetpack could be a source of bugs in the future. Any particular reason why it can't be called host_tracking_id in both places?
Also I think generally speaking partner_tracking_id or partner_tracking_code is better, because it lines up with the naming we give other partner things like "partner key" and "partner secret"
Contributor
Author
There was a problem hiding this comment.
No reason. I can make that change. 😄
… cancelling a plan
4e81447 to
e8c14c7
Compare
e8c14c7 to
0d55f4d
Compare
Contributor
Author
|
Deployed r170009-wpcom to change tracking parameter in API to |
oskosk
added a commit
that referenced
this pull request
Feb 27, 2018
oskosk
added a commit
that referenced
this pull request
Feb 27, 2018
* update changelog.txt * Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink * Add changelog entry for #8243 * Add changelog entry for #8296 * Add changelog entry for #8367 * Add changelog entry for #8686 * Add changelog entry for #8707 * Add changelog entry for #8709 and #8714 * Add changelog entry for #8729 * Add changelog entry for #8777 * Add changelog entry for #8780 * Add changelog entry for #8786 * Add changelog entry for #8787 * Add changelog entry for #8801 #8805 #8832 #8865 and #8804 * Add changelog entry for #8817 * Add changelog entry for #8822 * Add changelog entry for #8823 * Add changelog entry for #8829 * Add changelog entry for #8834 * move some items to major enhancements * Add changelog entry for #8836 * Add changelog entry for #8839 * Add changelog entry for #8861 * Add changelog entry for #8862 * Add changelog entry for #8863 * Add changelog entry for #8866 * Add changelog entry for #8870 * Add changelog entry for #8874 * Add changelog entry for #8875 * Add changelog entry for #8881 * Add changelog entry for #8890 * Add changelog entry for #8911 * Add changelog entry for #8927 * Add changelog entry for #8931 * Add changelog entry for #8933 * Add changelog entry for #8930 * fix wording * typo * minor fixes * replace partner scripts for Jetpack Start in changelog entry * Update to-test.md * Update to-test.md * minor style fixes to to-test.md * minor style fixes to to-test.md * minor fixes on to-test.md * Add changelog entry for #8868 * Add changelog entry for #8844 * Add changelog entry for #8664 * Add changelog entry for #8935 * Add changelog entry for #8425 * Add changelog entry for #8625
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging plan provisions and cancellations, I've noticed that users will often create various clones of sites and will move a domain name around those sites.
This sometimes results in the plan for a given site being cancelled when it probably shouldn't.
We have logs in place on WordPress.com to track when a partner provisions or cancels a plan, but it sure would be nice if we could tell exactly which site the partner intended on provisioning or cancelling the plan for. After this PR, hosts will be allowed to pass in a
--host_tracking_idargument which will help in debugging.To test:
For instructions on setting up a partner ID and secret, see: PCYsg-eDL-p2
sh jetpack/bin/partner-provision.sh --partner_id={PARTNER_ID} --partner_secret={PARTNER_SECRET} --user={LOCAL_WP_USER_ID} --plan=professional --host_tracking_id=$some_numeric_valueidhas the value that was sent viahost_tracking_idChangelog entry