Skip to content

Admin Page: Show app dismissal button only for admin users in Dashboard#8844

Merged
jeherve merged 1 commit intomasterfrom
fix/editor-app-dismissal
Feb 27, 2018
Merged

Admin Page: Show app dismissal button only for admin users in Dashboard#8844
jeherve merged 1 commit intomasterfrom
fix/editor-app-dismissal

Conversation

@oskosk
Copy link
Copy Markdown
Contributor

@oskosk oskosk commented Feb 14, 2018 •
edited
Loading

Fixes #7299 in a way.

Changes proposed in this Pull Request:

  • Makes the dismissal link only be shown for users that can manage options.
    Another option would be replacing update_option for something per user.

Testing instructions:

  1. Checkout this branch
  2. Build the admin page
  3. Connect Jetpack if it's not. Create an editor user if there's not one on the site.
  4. Login in incognito with that editor
  5. Visit the Jetpack Dashboard, scroll to the bottom until you see the Apps card.
  6. Confirm that you don't see the dismissal link

Before

image

After

image

Proposed changelog entry for your changes:

Only show dismissal button in Apps card for admin users.

@oskosk oskosk added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. Admin Page React-powered dashboard under the Jetpack menu labels Feb 14, 2018
@oskosk oskosk added this to the 5.9 milestone Feb 14, 2018
@oskosk oskosk requested a review from dereksmart February 14, 2018 20:07
@oskosk oskosk requested a review from a team as a code owner February 14, 2018 20:07
@oskosk oskosk changed the title Admin Page Only show app dismissal button only for admin users in admin page dashboard Admin Page: Show app dismissal button only for admin users in Dashboard Feb 17, 2018
dereksmart
dereksmart approved these changes Feb 27, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works!

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 27, 2018
jeherve
jeherve approved these changes Feb 27, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Merging.

@jeherve jeherve merged commit c5aea23 into master Feb 27, 2018
@jeherve jeherve deleted the fix/editor-app-dismissal branch February 27, 2018 14:27
oskosk added a commit that referenced this pull request Feb 27, 2018
@oskosk
Add changelog entry for #8844
1e5d7e2
oskosk added a commit that referenced this pull request Feb 27, 2018
@oskosk
Changelog 5.9: running changelog (#8819)
1174ef5 
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

@dereksmart dereksmart dereksmart approved these changes

Assignees

No one assigned

Labels

Admin Page React-powered dashboard under the Jetpack menu Bug When a feature is broken and / or not performing as intended

Projects

None yet

Milestone

5.9

Development

Successfully merging this pull request may close these issues.

Admin Page: Editors cannot dismiss App promo card

5 participants

@oskosk @jeherve @dereksmart @kraftbj @matticbot