Admin Page: Fix all eslint warnings except those related to React ES6 classes#8861
Merged
Admin Page: Fix all eslint warnings except those related to React ES6 classes#8861
Conversation
ec9214a to
b2ec654
Compare
withinboredom
approved these changes
Feb 16, 2018
Contributor
withinboredom
left a comment
There was a problem hiding this comment.
Lot's of changes, but lets see what breaks!
Contributor
Author
|
Thanks! I'm merging. The page built ok locally and with the Jetpack builder and this will help other devs. If anything breaks I'll fix asap. |
oskosk
added a commit
that referenced
this pull request
Feb 27, 2018
oskosk
added a commit
that referenced
this pull request
Feb 27, 2018
* update changelog.txt * Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink * Add changelog entry for #8243 * Add changelog entry for #8296 * Add changelog entry for #8367 * Add changelog entry for #8686 * Add changelog entry for #8707 * Add changelog entry for #8709 and #8714 * Add changelog entry for #8729 * Add changelog entry for #8777 * Add changelog entry for #8780 * Add changelog entry for #8786 * Add changelog entry for #8787 * Add changelog entry for #8801 #8805 #8832 #8865 and #8804 * Add changelog entry for #8817 * Add changelog entry for #8822 * Add changelog entry for #8823 * Add changelog entry for #8829 * Add changelog entry for #8834 * move some items to major enhancements * Add changelog entry for #8836 * Add changelog entry for #8839 * Add changelog entry for #8861 * Add changelog entry for #8862 * Add changelog entry for #8863 * Add changelog entry for #8866 * Add changelog entry for #8870 * Add changelog entry for #8874 * Add changelog entry for #8875 * Add changelog entry for #8881 * Add changelog entry for #8890 * Add changelog entry for #8911 * Add changelog entry for #8927 * Add changelog entry for #8931 * Add changelog entry for #8933 * Add changelog entry for #8930 * fix wording * typo * minor fixes * replace partner scripts for Jetpack Start in changelog entry * Update to-test.md * Update to-test.md * minor style fixes to to-test.md * minor style fixes to to-test.md * minor fixes on to-test.md * Add changelog entry for #8868 * Add changelog entry for #8844 * Add changelog entry for #8664 * Add changelog entry for #8935 * Add changelog entry for #8425 * Add changelog entry for #8625
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes eslint warnings on the Admin Page's code.
After this PR is merged eslint warnings are down from
1193to69. The only remaining warnings are shown all related to thereact/prefer-es6-classrule.Testing instructions:
node_modules/.bin/eslint --ext .js --ext .jsx _inc/client -c .eslintrcreact/prefer-es6-classrule.yarn buildand confirm that the admin page built ok.React class warnings are going to be address by #8714.
Changes proposed in this Pull Request:
varusage after runningRun eslint --fixprefer-const.import-docblock.brace-style.operator-linebreak.brace-style.react-no-danger.wpcalypso/i18n-no-this-translate.valid-jsdoc.react/jsx-no-bindrule to be ignored temporarily because this pattern is extensively used.Changelog entry