Skip to content

Admin Page: Remove prop-types related warnings from development builds#8709

Merged
oskosk merged 7 commits intomasterfrom
update/more-prop-types-codemod
Feb 13, 2018
Merged

Admin Page: Remove prop-types related warnings from development builds#8709
oskosk merged 7 commits intomasterfrom
update/more-prop-types-codemod

Conversation

@oskosk
Copy link
Copy Markdown
Contributor

@oskosk oskosk commented Feb 1, 2018 •
edited
Loading

Changes proposed in this Pull Request:

  • Applied the prop-types codemod
  • Updates react-router (and history and react-redux-router) to use a version that relies on prop-types.

Testing instructions:

  • Check this branch
  • Build the admin page
  • Visit the Jetpack Dashboard and Settings pages.
  • Expect to see no warnings like these: 
    Warning: Accessing PropTypes via the main React package is deprecated, and will be removed in  React v16.0. Use the latest available v15.* prop-types package from npm instead.
  • Switch around tabs and Jetpack Admin Pages to confirm the routes work OK.

Proposed changelog entry for your changes:

Changelog entry

  • We made Jetpack's Admin Page javascript code be fully compatible with React 16.

(this changelog entry will be shared among a few PRs.)

@oskosk oskosk added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu [Type] Janitorial labels Feb 1, 2018
@oskosk oskosk requested review from a team and jeherve as code owners February 1, 2018 15:23
@oskosk oskosk changed the title Admin Page: Run react-proptypes codemod Admin Page: Run prop-types codemod Feb 1, 2018
@oskosk oskosk removed the Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Feb 1, 2018
@oskosk oskosk changed the title Admin Page: Run prop-types codemod Admin Page: Remove prop-types related warnings from development builds Feb 1, 2018
@oskosk oskosk added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Feb 1, 2018
@oskosk oskosk requested review from dereksmart and zinigor February 1, 2018 17:41
@oskosk oskosk force-pushed the update/more-prop-types-codemod branch 2 times, most recently from 1113e1c to 038f4c6 Compare February 6, 2018 15:46
@oskosk oskosk mentioned this pull request Feb 6, 2018
Closed
7 tasks
@oskosk oskosk added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Feb 7, 2018
@oskosk oskosk force-pushed the update/more-prop-types-codemod branch from 18ccad2 to 038f4c6 Compare February 7, 2018 17:04
@oskosk oskosk added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 7, 2018
@oskosk oskosk force-pushed the update/more-prop-types-codemod branch from 038f4c6 to f48d014 Compare February 8, 2018 18:58
@oskosk oskosk added this to the 5.9 milestone Feb 9, 2018
dereksmart
dereksmart approved these changes Feb 13, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs great! :shipit:

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 13, 2018
@oskosk oskosk merged commit 4b4b895 into master Feb 13, 2018
@oskosk oskosk deleted the update/more-prop-types-codemod branch February 13, 2018 22:09
oskosk added a commit that referenced this pull request Feb 27, 2018
@oskosk
Add changelog entry for #8709 and #8714
3d910f4
oskosk added a commit that referenced this pull request Feb 27, 2018
@oskosk
Changelog 5.9: running changelog (#8819)
1174ef5 
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dereksmart dereksmart dereksmart approved these changes

@jeherve jeherve Awaiting requested review from jeherve

@zinigor zinigor Awaiting requested review from zinigor

Assignees

No one assigned

Labels

Admin Page React-powered dashboard under the Jetpack menu Touches WP.com Files [Type] Janitorial

Projects

None yet

Milestone

5.9

Development

Successfully merging this pull request may close these issues.

4 participants

@oskosk @dereksmart @kraftbj @matticbot