Skip to content

Properly handle display of Lazy Images setting.#8780

Merged
oskosk merged 1 commit intomasterfrom
fix/lazy-images-undefined
Feb 8, 2018
Merged

Properly handle display of Lazy Images setting.#8780
oskosk merged 1 commit intomasterfrom
fix/lazy-images-undefined

Conversation

@zinigor
Copy link
Copy Markdown
Contributor

@zinigor zinigor commented Feb 7, 2018 •
edited by oskosk
Loading

This allows the setting UI to hide Lazy Images individually when they are filtered out, plus properly display search results.

Fixes #8778.

Changes proposed in this Pull Request:

  • Fixed Lazy Images setting display in Settings for search results and special cases like filter usage.

Testing instructions:

  • Try to filter out lazy images as a module using this snippet:
add_filter( 'jetpack_get_available_modules', function( $active ) {
	return array_diff_key( $active, array( 'lazy-images' => 'Does not matter' ) );
} );
  • Make sure you don't see the module at all when you open the Writing tab, or search for something like lazy.

Changelog entry

  • We now hide settings for Lazy Images and Photon when the modules are not enabled due to being filtered out by jetpack_get_available_modules.

@zinigor
Properly handle display of Lazy Images setting.
183d92c 
Fixes #8778. This allows the setting UI to hide Lazy Images individually when they are filtered out, plus properly display search results.
@zinigor zinigor added [Status] Needs Review This PR is ready for review. [Feature] Lazy Images labels Feb 7, 2018
@zinigor zinigor requested a review from ebinnion February 7, 2018 11:38
@zinigor zinigor requested a review from a team as a code owner February 7, 2018 11:38
oskosk
oskosk approved these changes Feb 7, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests great! LGTM

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 7, 2018
@oskosk oskosk added this to the 5.9 milestone Feb 8, 2018
@oskosk oskosk merged commit 99210cd into master Feb 8, 2018
@oskosk oskosk deleted the fix/lazy-images-undefined branch February 8, 2018 17:29
@oskosk oskosk removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 8, 2018
@mrjarbenne mrjarbenne mentioned this pull request Feb 10, 2018
Closed
oskosk added a commit that referenced this pull request Feb 27, 2018
@oskosk
Add changelog entry for #8780
504f6e0
oskosk added a commit that referenced this pull request Feb 27, 2018
@oskosk
Changelog 5.9: running changelog (#8819)
1174ef5 
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebinnion ebinnion Awaiting requested review from ebinnion

1 more reviewer

@oskosk oskosk oskosk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Feature] Lazy Images

Projects

None yet

Milestone

5.9

Development

Successfully merging this pull request may close these issues.

3 participants

@zinigor @oskosk @matticbot